Add ES|QL full text functions challenges#759
Merged
carlosdelest merged 13 commits intoelastic:masterfrom Mar 21, 2025
Merged
Conversation
ioanatia
reviewed
Mar 20, 2025
ioanatia
left a comment
There was a problem hiding this comment.
looking at the changes in the track.py the ES|QL and query DSL queries should be equivalent (same queries are being used, same queried fields, same source fields being retrieved, same size etc).
|
|
||
|
|
||
| def register(registry): | ||
| registry.register_param_source("query-string-search", QueryParamSource) |
There was a problem hiding this comment.
Is there any impact from this renaming?
Member
Author
There was a problem hiding this comment.
The param-source attribute for the query-string-search operation has been changed - no other changes are needed as just the param source is changed and not the actual query name.
ioanatia
approved these changes
Mar 20, 2025
ioanatia
reviewed
Mar 20, 2025
ioanatia
reviewed
Mar 20, 2025
wikipedia/track.py
Outdated
There was a problem hiding this comment.
there's a linting CI error that we should fix before merging - there are some extra lines here too that we prob want to remove
tteofili
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ES|QL full text functions challenges to existing tracks:
Search use case
Check that full text functions behave correctly for a full text search scenario with enough text data. Sorting by score will be used in all queries.
Observability use case
Perform filtering using full text functions for partial word matches, with no scoring.
Closes elastic/elasticsearch#124649