Skip to content

Fix misplaced comma in TSDB track#747

Merged
gbanasiak merged 2 commits intoelastic:masterfrom
gbanasiak:tsdb-misplaced-comma
Feb 18, 2025
Merged

Fix misplaced comma in TSDB track#747
gbanasiak merged 2 commits intoelastic:masterfrom
gbanasiak:tsdb-misplaced-comma

Conversation

@gbanasiak
Copy link
Contributor

#743 introduced this problem:

% esrally info --track=tsdb --track-params="index_mode:standard"

    ____        ____
   / __ \____ _/ / /_  __
  / /_/ / __ `/ / / / / /
 / _, _/ /_/ / / / /_/ /
/_/ |_|\__,_/_/_/\__, /
                /____/

[ERROR] Cannot info. Could not load '/Users/grzegorz/.rally/benchmarks/tracks/default/tsdb/track.json': Expecting ',' delimiter: line 510 column 9 (char 10509). Lines containing the error:

          "iterations": 100
        }
        
        {
--------^ Error is here
          "operation": "esql-fetch-500",
          "warmup-iterations": 50,

The complete track has been written to '/var/folders/fy/mlp_1k2s5yx_vm9gt82dc3140000gn/T/tmpso8ke_8q.json' for diagnosis.

@gbanasiak gbanasiak requested review from a team and salvatore-campagna February 18, 2025 16:44
Copy link
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbanasiak gbanasiak merged commit 273d329 into elastic:master Feb 18, 2025
13 checks passed
@gbanasiak gbanasiak deleted the tsdb-misplaced-comma branch February 18, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments