ES|QL JOIN: query templates to reduce redundancy#728
Merged
luigidellaquila merged 4 commits intoelastic:masterfrom Jan 17, 2025
Merged
ES|QL JOIN: query templates to reduce redundancy#728luigidellaquila merged 4 commits intoelastic:masterfrom
luigidellaquila merged 4 commits intoelastic:masterfrom
Conversation
alex-spies
reviewed
Jan 17, 2025
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
I think we change the default benchmark w.r.t. the no match tasks - let's double check. Otherwise this LGTM, this is lovely!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring ES|QL JOIN track to make it less verbose and repetitive.