Skip to content

Temporarily disable joins in IT#726

Closed
gareth-ellis wants to merge 1 commit intomasterfrom
disable-joins-it
Closed

Temporarily disable joins in IT#726
gareth-ellis wants to merge 1 commit intomasterfrom
disable-joins-it

Conversation

@gareth-ellis
Copy link
Member

elastic/elasticsearch#120073 has meant that lookup indices in the joins track are left in yellow. Discussion is ongoing, but to unblock CI i suggest temporarily disabling joins for IT tests

@gareth-ellis gareth-ellis requested a review from a team January 15, 2025 09:48
Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnhatn fyi

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbanasiak
Copy link
Contributor

The "yellow" left-over from joins came up in #719 which passed IT tests successfully. Why?

cc @luigidellaquila

@gareth-ellis
Copy link
Member Author

No, they started after the Elasticsearch PR stated in the description, that changes the default for lookup indices to have 1 replica, whilst before the default was 0

@gbanasiak
Copy link
Contributor

Can we add auto_expand_replicas to all join indices instead? It's easy to skip, way harder to remember to reintroduce later.

@gareth-ellis
Copy link
Member Author

You mean set it to false ? We can do, if the ESQL team are happy with that? @martijnvg is going to discuss later if there are any other changes required

I'll test first it works and then update the PR

@gbanasiak
Copy link
Contributor

You mean set it to false ?

I would try with:

"auto_expand_replicas": "0-all"

@gareth-ellis
Copy link
Member Author

created #727

@gareth-ellis
Copy link
Member Author

Will close this for now, #727 seems to have fixed it

@gareth-ellis gareth-ellis deleted the disable-joins-it branch August 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments