Skip to content

Two more benchmarks for partial sorting with ESQL#703

Merged
craigtaverner merged 2 commits intoelastic:masterfrom
craigtaverner:distance_sort_partial
Nov 5, 2024
Merged

Two more benchmarks for partial sorting with ESQL#703
craigtaverner merged 2 commits intoelastic:masterfrom
craigtaverner:distance_sort_partial

Conversation

@craigtaverner
Copy link
Contributor

These cannot be replicated in _search since that only supports what can be pushed down to lucene, and this feature explicitly only pushes down part of the sort, and then does the other part in the compute engine.

These cannot be replicated in _search since that only supports what can be pushed down to lucene, and this feature explicitly only pushes down part of the sort, and then does the other part in the compute engine.
@craigtaverner craigtaverner requested a review from iverase November 4, 2024 17:33
"tags": ["distance", "esql", "sort"]
},
{
"operation": "distanceSort-esql-partial",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my curiosity, why do we have different warmups and iterations in these new benchmarks and the rationally behind this numbers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose numbers that are related to the inverse of the latency. So a very long running benchmark (like the 10-20 seconds of the sort before the performance) should have very few iterations (we really don't care about precision on such long queries), while fast benchmarks (10-50ms) usually have high iteration counts, so we can get more stable, and predictable results. But in general I've also started moving away from really high numbers like 200/100 because they do not seem more stable than numbers like 50/50. I think variability is coming from the cloud infrastructure, so high iteration counts are costing time and money without bringing value.

@craigtaverner craigtaverner merged commit 8705a2b into elastic:master Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments