Skip to content

Added two more distancefilter benchmarks and updated iterations after new optimizations#693

Merged
craigtaverner merged 1 commit intoelastic:masterfrom
craigtaverner:distance_sort
Oct 17, 2024
Merged

Added two more distancefilter benchmarks and updated iterations after new optimizations#693
craigtaverner merged 1 commit intoelastic:masterfrom
craigtaverner:distance_sort

Conversation

@craigtaverner
Copy link
Contributor

The recent optimization of ESQL distance-sort allows us to benchmark that properly. That PR also did a few bug-fixes to distance filtering, so we added an alternative version of the query that is now also optimized.

…zations

The recent optimization of ESQL distance-sort allows us to benchmark that properly. That PR also did a few bug-fixes to distance filtering, so we added an alternative version of the query that is now also optimized.
@craigtaverner craigtaverner requested a review from iverase October 17, 2024 08:41
"body": {
"query": {
"bool": {
"must": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a filter instead of must?

},
{
"bool": {
"must_not": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a must not, could we use a disjoint spatial relationship?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disjoint version was the original version. This is an alternative query that deliberately does things differently, to see if that makes a difference to the performance. It does not seem to make any difference.

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve the _search, wdyt?

@craigtaverner
Copy link
Contributor Author

I think we can improve the _search, wdyt?

The original distanceFilterCount200x300 has been there for a few months. This new distanceFilterCount200x300-alt is deliberately an alternative way of doing the same thing, in particular the must_not approach instead of a disjoint. The benchmark is simply testing whether there is any performance difference between the two approaches.

@craigtaverner craigtaverner merged commit dc2e963 into elastic:master Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments