Skip to content

Include a variable to control synthetic_source_keep parameter#682

Merged
salvatore-campagna merged 6 commits intoelastic:masterfrom
salvatore-campagna:feature/synthetic-source-keep-array
Sep 30, 2024
Merged

Include a variable to control synthetic_source_keep parameter#682
salvatore-campagna merged 6 commits intoelastic:masterfrom
salvatore-campagna:feature/synthetic-source-keep-array

Conversation

@salvatore-campagna
Copy link
Contributor

@salvatore-campagna salvatore-campagna commented Sep 30, 2024

This PR introduces a new track parameter, synthetic_source_keep which is used to control the
behaviour of synthetic source for all field types. It can have values none, arrays or all (all
not usable when set at index level).
See elastic/elasticsearch#112706 to understand the effect of each value.

Later on we will use this to change the behaviour in our nightlies and run benchmarks on both elastic/logs
and elastic/security using value arrays.

This needs backporting to 8.15

Later on we will use this to change the behavior in our nightlies and run
benchmarks on both `elastic/logs` and `elastic/security`.
Copy link
Contributor

@kkrik-es kkrik-es Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is not allowed at the index level, as it effectively disables synthetic source. The only values are none, same as default, and arrays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

public static final Setting<SourceKeepMode> SYNTHETIC_SOURCE_KEEP_INDEX_SETTING = Setting.enumSetting(
        SourceKeepMode.class,
        "index.mapping.synthetic_source_keep",
        SourceKeepMode.NONE,
        value -> {
            if (value == SourceKeepMode.ALL) {
                throw new IllegalArgumentException("index.mapping.synthetic_source_keep can't be set to [" + value.toString() + "]");
            }
        },
        Setting.Property.IndexScope,
        Setting.Property.ServerlessPublic
    );

@salvatore-campagna salvatore-campagna merged commit 0a09c6a into elastic:master Sep 30, 2024
@github-actions
Copy link

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 682

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

salvatore-campagna added a commit to salvatore-campagna/rally-tracks that referenced this pull request Sep 30, 2024
…tic#682)

This PR introduces a new track parameter, `synthetic_source_keep` which is used to control the
behaviour of synthetic source for all field types. It can have values `none`, `arrays` or `all` (`all`
not usable when set at index level).
See elastic/elasticsearch#112706 to understand the effect of each value.

Later on we will use this to change the behaviour in our nightlies and run benchmarks on both `elastic/logs`
and `elastic/security` using value `arrays`.
salvatore-campagna added a commit that referenced this pull request Oct 1, 2024
#684)

This PR introduces a new track parameter, `synthetic_source_keep` which is used to control the
behaviour of synthetic source for all field types. It can have values `none`, `arrays` or `all` (`all`
not usable when set at index level).
See elastic/elasticsearch#112706 to understand the effect of each value.

Later on we will use this to change the behaviour in our nightlies and run benchmarks on both `elastic/logs`
and `elastic/security` using value `arrays`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments