Include a variable to control synthetic_source_keep parameter#682
Merged
salvatore-campagna merged 6 commits intoelastic:masterfrom Sep 30, 2024
Merged
Conversation
Later on we will use this to change the behavior in our nightlies and run benchmarks on both `elastic/logs` and `elastic/security`.
kkrik-es
reviewed
Sep 30, 2024
elastic/logs/README.md
Outdated
Contributor
There was a problem hiding this comment.
all is not allowed at the index level, as it effectively disables synthetic source. The only values are none, same as default, and arrays.
Contributor
Author
There was a problem hiding this comment.
I see
public static final Setting<SourceKeepMode> SYNTHETIC_SOURCE_KEEP_INDEX_SETTING = Setting.enumSetting(
SourceKeepMode.class,
"index.mapping.synthetic_source_keep",
SourceKeepMode.NONE,
value -> {
if (value == SourceKeepMode.ALL) {
throw new IllegalArgumentException("index.mapping.synthetic_source_keep can't be set to [" + value.toString() + "]");
}
},
Setting.Property.IndexScope,
Setting.Property.ServerlessPublic
);
gbanasiak
reviewed
Sep 30, 2024
kkrik-es
approved these changes
Sep 30, 2024
gbanasiak
approved these changes
Sep 30, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
salvatore-campagna
added a commit
to salvatore-campagna/rally-tracks
that referenced
this pull request
Sep 30, 2024
…tic#682) This PR introduces a new track parameter, `synthetic_source_keep` which is used to control the behaviour of synthetic source for all field types. It can have values `none`, `arrays` or `all` (`all` not usable when set at index level). See elastic/elasticsearch#112706 to understand the effect of each value. Later on we will use this to change the behaviour in our nightlies and run benchmarks on both `elastic/logs` and `elastic/security` using value `arrays`.
salvatore-campagna
added a commit
that referenced
this pull request
Oct 1, 2024
#684) This PR introduces a new track parameter, `synthetic_source_keep` which is used to control the behaviour of synthetic source for all field types. It can have values `none`, `arrays` or `all` (`all` not usable when set at index level). See elastic/elasticsearch#112706 to understand the effect of each value. Later on we will use this to change the behaviour in our nightlies and run benchmarks on both `elastic/logs` and `elastic/security` using value `arrays`.
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new track parameter,
synthetic_source_keepwhich is used to control thebehaviour of synthetic source for all field types. It can have values
none,arraysorall(allnot usable when set at index level).
See elastic/elasticsearch#112706 to understand the effect of each value.
Later on we will use this to change the behaviour in our nightlies and run benchmarks on both
elastic/logsand
elastic/securityusing valuearrays.This needs backporting to
8.15