Skip to content

Comments

Continue backport on error#681

Merged
gbanasiak merged 1 commit intoelastic:masterfrom
gbanasiak:adjust-backport
Sep 25, 2024
Merged

Continue backport on error#681
gbanasiak merged 1 commit intoelastic:masterfrom
gbanasiak:adjust-backport

Conversation

@gbanasiak
Copy link
Contributor

When backport does not find a branch to backport to it returns with an error failing GH action step which in turn fails entire job (see example in https://github.com/elastic/rally-tracks/actions/runs/11019352166). This will happen frequently as not every PR will be labeled with backport-to-*.

The intention here is to prevent such error from failing entire job without repeating ourselves, i.e. including all possible backport-to-* labels in the if statement of the job. The list of backport-allowed branches is already defined in targetBranchChoices in .backportrc.json.

@gbanasiak gbanasiak merged commit d991a14 into elastic:master Sep 25, 2024
@gbanasiak gbanasiak deleted the adjust-backport branch September 25, 2024 14:56
@gbanasiak
Copy link
Contributor Author

With this change failure() condition in the Debug log step will never be true, but I'm leaving this as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants