Include ability to force merge segments in elastic/security#657
Merged
salvatore-campagna merged 3 commits intoelastic:masterfrom Sep 11, 2024
Merged
Conversation
salvatore-campagna
changed the title
elastic/security
Contributor
Author
|
I tested this running it with a stateful configuration and it works. |
gareth-ellis
approved these changes
Sep 9, 2024
Member
gareth-ellis
left a comment
gareth-ellis
left a comment
There was a problem hiding this comment.
LGTM, Since the default action is to not run, I don't think we need the check for whether we are running serverless or not
salvatore-campagna
added a commit
to salvatore-campagna/rally-tracks
that referenced
this pull request
Sep 11, 2024
salvatore-campagna
added a commit
that referenced
this pull request
Sep 17, 2024
salvatore-campagna
added a commit
to salvatore-campagna/rally-tracks
that referenced
this pull request
Sep 17, 2024
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force merging allows us to compare segment size and overall storage size reasoning about
storage saving. The security track is missing a way to force merge.
We are not going to set this parameter in nightlies but we still would like to have it for ad-hoc runs, since it makes reasoning about storage footprint easier.
This needs back-porting to Rally
8.15branch.