Skip to content

Synthetic source does not still support copy_to #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salvatore-campagna merged 13 commits into from
Sep 5, 2024
Merged

Synthetic source does not still support copy_to #652

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ae62c07
fix: synthetic source does not still support copy_to
salvatore-campagna Aug 30, 2024
8505cec
fix: use kubernetes.event.message instead of message
salvatore-campagna Aug 30, 2024
7cd2ec3
fix: unconditionally use kubernetes.event.message in place of message
salvatore-campagna Sep 3, 2024
59f6738
fix: introduce a logsdb specific workflows directory
salvatore-campagna Sep 3, 2024
0cbd1a9
fix: read the track param for the worflows folder
salvatore-campagna Sep 3, 2024
41ce3b4
fix: get or default workflows directory
salvatore-campagna Sep 3, 2024
7362f2e
lint: code format
salvatore-campagna Sep 3, 2024
ab2e5a4
Fix for logsdb mode. Add logsdb test
gareth-ellis Sep 4, 2024
21a4a6e
Add validation that the indicies we are testing against are in logsdb…
gareth-ellis Sep 4, 2024
c60be3a
Merge branch 'master' into fix/security-message-copy-to
elasticmachine Sep 5, 2024
46214a3
Auto skip ilm insert
gareth-ellis Sep 5, 2024
af95bfd
fix: skip other component templates
salvatore-campagna Sep 5, 2024
639eb61
Mistake in %
gareth-ellis Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions elastic/security/templates/composable/security-metricbeat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14208,7 +14208,9 @@
}
},
"message" : {
{% if index_mode != "logsdb" %}
"copy_to" : "message",
{% endif %}
"norms" : false,
"type" : "text"
},
Expand Down
4 changes: 4 additions & 0 deletions elastic/security/workflows/hosts/10.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,11 @@
"include_unmapped": true
},
{
{% if index_mode != "logsdb" %}
"field": "message",
{% else %}
"field": "kubernetes.event.message",
{% endif %}
"include_unmapped": true
},
{
Expand Down
4 changes: 4 additions & 0 deletions elastic/security/workflows/hosts/8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,11 @@
"include_unmapped": true
},
{
{% if index_mode != "logsdb" %}
"field": "message",
{% else %}
"field": "kubernetes.event.message",
Comment thread
gareth-ellis marked this conversation as resolved.
Outdated
{% endif %}
"include_unmapped": true
},
{
Expand Down
4 changes: 4 additions & 0 deletions elastic/security/workflows/hosts/9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,11 @@
"include_unmapped": true
},
{
{% if index_mode != "logsdb" %}
"field": "message",
{% else %}
"field": "kubernetes.event.message",
{% endif %}
"include_unmapped": true
},
{
Expand Down
4 changes: 4 additions & 0 deletions elastic/security/workflows/network/11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,11 @@
"include_unmapped": true
},
{
{% if index_mode != "logsdb" %}

@salvatore-campagna salvatore-campagna Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like our template engine does not process files in the workflows directory. As a result we are not able to conditionally execute the query on message or kubernetes.even.message. I will just unconditionally execute it using kubernetes.even.message that is the original field name. After we introduce support for copy_to we can restore the original behaviour.

"field": "message",
{% else %}
"field": "kubernetes.event.message",
{% endif %}
"include_unmapped": true
},
{
Expand Down