Introduce an index_mode param into the elastic/security Rally track#640
Merged
salvatore-campagna merged 4 commits intoelastic:masterfrom Aug 21, 2024
Conversation
Contributor
Author
|
Double-checked that |
martijnvg
approved these changes
Aug 21, 2024
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - I left a comment about security adoption, doesn't block this PR. I think the name pattern / not using builtin stack logging template results in logsdb never to be enabled.
| ".fleet_globals-1", | ||
| ".fleet_agent_id_verification-1" | ||
| ".fleet_agent_id_verification-1", | ||
| "track-shared-logsdb-mode" |
Member
There was a problem hiding this comment.
This are just my observations for security and logsdb:
- The index pattern doesn't match with logs-*, the pattern used here is:
.logs-endpoint.action.responses-* - The built in logging stack templates are not used here, which mean logsdb will never be enabled automatically.
gareth-ellis
approved these changes
Aug 21, 2024
Member
gareth-ellis
left a comment
There was a problem hiding this comment.
LGTM - remember this will need backporting to 8.15 too
salvatore-campagna
added a commit
to salvatore-campagna/rally-tracks
that referenced
this pull request
Aug 21, 2024
…ck (elastic#640) The index_mode parameter will be used to run Rally benchmarks comparing indexing using standard and logsdb mode for the elastic/security track. Enabling LogsDB is done by means of a component template which is added and later used if the index_mode is provided. In case it is missing no index mode will be used which will default to standard.
salvatore-campagna
added a commit
that referenced
this pull request
Aug 21, 2024
…ck (#640) (#641) The index_mode parameter will be used to run Rally benchmarks comparing indexing using standard and logsdb mode for the elastic/security track. Enabling LogsDB is done by means of a component template which is added and later used if the index_mode is provided. In case it is missing no index mode will be used which will default to standard.
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
index_modeparameter will be used to run Rally benchmarks comparingindexing using
standardandlogsdbmode for theelastic/securitytrack.Enabling LogsDB is done by means of a component template which is added and
later used if the
index_modeis provided. In case it is missing no index modewill be used which will default to
standard.