[ES-8187] ES|QL elastic/logs scale testing challenge#618
Closed
favilo wants to merge 14 commits intoelastic:masterfrom
Closed
[ES-8187] ES|QL elastic/logs scale testing challenge#618favilo wants to merge 14 commits intoelastic:masterfrom
favilo wants to merge 14 commits intoelastic:masterfrom
Conversation
added 12 commits
April 12, 2024 11:13
bpintea
reviewed
Jun 17, 2024
bpintea
left a comment
bpintea
left a comment
There was a problem hiding this comment.
I've left some comments mostly concerning queries that might no longer be needed.
I think it'd be great if we only have those queries present that we want timing details about.
Contributor
craigtaverner
approved these changes
Jun 25, 2024
Contributor
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
Approved, but I wonder were all four of these really long running? If not, we should not push the iteration count down for fast queries.
Contributor
Yes. |
Contributor
|
#705 includes the queries from this PR, so I'll rework it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding special queries specifically for scale testing ESQL queries