Add operation for sub-string-terms #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two operations to compare the speed of the `terms` agg run on strings as a sub-aggregation.
Member
Author
|
Sorry for the force push! I was missing a bunch of work that I'd done locally and forgotten to push. |
|
Doh, this fell off my radar. Im reviewing it now! |
hub-cap
approved these changes
Jun 30, 2020
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
LGTM, I will merge and backport tomorrow.
hub-cap
pushed a commit
that referenced
this pull request
Jul 1, 2020
Adds two operations to compare the speed of the `terms` agg run on strings as a sub-aggregation.
hub-cap
pushed a commit
that referenced
this pull request
Jul 1, 2020
Adds two operations to compare the speed of the `terms` agg run on strings as a sub-aggregation.
hub-cap
pushed a commit
that referenced
this pull request
Jul 1, 2020
Adds two operations to compare the speed of the `terms` agg run on strings as a sub-aggregation.
|
Forgot to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two operations to compare the speed of the
termsagg run onstrings as a sub-aggregation to test elastic/elasticsearch#57758