This repository was archived by the owner on Jan 27, 2023. It is now read-only.
Merged
Conversation
added 2 commits
June 16, 2020 10:54
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
|
ruflin
approved these changes
Jun 16, 2020
Collaborator
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Change LGTM.
Please do me the favor that after this is merged and deployed to spin up Kibana and check if all the things are still working as expected.
thomasneirynck
pushed a commit
to thomasneirynck/package-storage
that referenced
this pull request
Sep 28, 2021
Instead of dynamically serving the package endpoint, an `index.json` file is pregenerated when run `mage build` for each package. This simplifies the serving code.
A package `p` was created to share the code. The naming is not optimal but `package` cannot be used as it is a reserved term. A better structure will be found later.
The `.tar.gz` handler can also be removed, as it was only there as a placeholder for the matching of the endpoint. Now that `/package/{name}` endpoint is removed, it's not needed anymore. Overall there are now only 2 endpoints left. CatchAll to match files and the `/search` endpoint handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: elastic/package-registry#466 (comment)
Changes:
dev/generatorto build packages-dry-runto validate packagesIt would be possible to get rid of building packages (and copying to
builddirectory) now, but it will break the integration tests as docker image requires packages to be present inpublic/package, wherepublicin a mount point. I will improve this in the next step, I need to modify package-registry source.