Skip to content
Merged
6 changes: 3 additions & 3 deletions .buildkite/pipeline.trigger.compliance.tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ steps:
EOF

# Generate each test we want to do.
compliance_test 9.1.0-SNAPSHOT 3.4.2
compliance_test 8.19.0-SNAPSHOT 3.4.2
compliance_test 9.0.1 3.3.5
compliance_test 9.2.0-SNAPSHOT 3.5.0
compliance_test 8.19.3 3.4.2
compliance_test 9.0.6 3.3.5
compliance_test 8.14.0 3.1.5
compliance_test 8.9.0 2.7.0

Expand Down
2 changes: 1 addition & 1 deletion .go-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.23.6
1.24.7
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/elastic/package-spec/v3

go 1.23.0
go 1.24.0

require (
Comment thread
jsoriano marked this conversation as resolved.
github.com/Masterminds/semver/v3 v3.4.0
Expand Down
10 changes: 7 additions & 3 deletions spec/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@
## This file documents changes in the package specification. It is NOT a package specification file.
## Newer entries go at the bottom of each in-development version.
##
- version: 3.5.0-next
- version: 3.6.0-next
changes:
# Pending on https://github.com/elastic/kibana/pull/186974
- description: Add support for `slo` assets.
type: enhancement
link: https://github.com/elastic/package-spec/pull/767
# Pending on https://github.com/elastic/kibana/issues/220294
- description: Add support for semantic_text field definition.
type: enhancement
link: https://github.com/elastic/package-spec/pull/807
- version: 3.5.0
changes:
- description: Add `duration` variable data type with `min_duration` and `max_duration` validation properties.
type: enhancement
link: https://github.com/elastic/package-spec/pull/948
Expand All @@ -22,7 +26,7 @@
- description: Add support for OTel collector configuration in input packages.
type: enhancement
link: https://github.com/elastic/package-spec/pull/975
- version: 3.4.2-next
- version: 3.4.2
changes:
- description: Add support for opentelemetry category.
type: enhancement
Expand All @@ -39,7 +43,7 @@
- description: Fix paths with slashes displayed on Windows.
type: bugfix
link: https://github.com/elastic/package-spec/pull/953
- description: Add support for lookup indices.
- description: Add support for lookup indices in transforms.
type: enhancement
link: https://github.com/elastic/package-spec/pull/936
- description: Fix dynamic_date_formats example type in data stream manifest schema.
Expand Down
8 changes: 5 additions & 3 deletions spec/content/kibana/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,15 @@ spec:
contentMediaType: "application/json"
pattern: '^.+\.json$'
versions:
- before: 3.6.0
patch:
- op: remove
path: "/contents/2" # remove SLO definitions
- before: 3.5.0
patch:
- op: remove
path: "/contents/5" # remove alerting rule template definitions
path: "/contents/4" # remove alerting rule template definitions
- before: 3.4.0
patch:
- op: remove
path: "/contents/3" # remove AI prompt definitions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed to /contents/2 since it is removed in the first JSON patch the second element

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and I don't like that no test detected this 😬

- op: remove
path: "/contents/2" # remove SLO definitions
2 changes: 1 addition & 1 deletion spec/integration/data_stream/fields/fields.spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ spec:

# JSON patches for newer versions should be placed on top
versions:
- before: 3.5.0
- before: 3.6.0
patch:
- op: remove
path: "/items/properties/type/enum/35" #remove semantic_text type
Expand Down
8 changes: 5 additions & 3 deletions spec/integration/kibana/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,14 @@ spec:
contentMediaType: "application/json"
pattern: '^.+\.json$'
versions:
- before: 3.5.0
- before: 3.6.0
patch:
- op: remove
path: "/contents/14" # remove alerting rule template definitions
- op: remove
path: "/contents/13" # remove SLO definitions
- before: 3.5.0
patch:
- op: remove
path: "/contents/13" # remove alerting rule template definitions
- before: 2.10.0
patch:
- op: remove
Expand Down
2 changes: 1 addition & 1 deletion test/packages/good_content/manifest.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
format_version: 3.5.0
format_version: 3.6.0
name: good_content
title: Good content package
description: >
Expand Down
2 changes: 1 addition & 1 deletion test/packages/good_v3/manifest.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
format_version: 3.5.0
format_version: 3.6.0
name: good_v3
title: Good package
description: This package is good for format version 3
Expand Down