Add alert rule kibana asset to package spec #918
Conversation
MichelLosier
force-pushed
the
support-alert-kbn-assets
branch
from
aeea206 to
b3b33d7
Compare
|
test integrations |
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#14648 |
| link: https://github.com/elastic/package-spec/pull/807 | ||
| - description: Add support for `alert` rule assets. | ||
| type: enhancement | ||
| link: https://github.com/elastic/package-spec/pull/918 |
There was a problem hiding this comment.
Does Fleet need changes to support these new assets? If it does, we will also need to add a patch in the versions sections of the spec. If it doesn't, we might include this change in 3.4.2-next.
There was a problem hiding this comment.
Sounds good, thanks for taking a look. Supporting this does require changes on the kibana end (original PR). We're pivoting on the direction for this and putting the work behind a feature flag. So I'm going to put this back into draft for now, and we'll ready this back up once the new kibana work is in place.
There was a problem hiding this comment.
If it requires changes in Kibana, even if they are not finished, I think it would be fine with continuing with this PR as is. Unless you expect big changes.
| link: https://github.com/elastic/package-spec/pull/807 | ||
| - description: Add support for `alert` rule assets. | ||
| type: enhancement | ||
| link: https://github.com/elastic/package-spec/pull/918 |
There was a problem hiding this comment.
If it requires changes in Kibana, even if they are not finished, I think it would be fine with continuing with this PR as is. Unless you expect big changes.
Yeah our approach is going to look at persisting more so a "rule template" saved object rather than directly an |
…#226085) ## Summary Resolves in part: #221633 Related to: elastic/package-spec#918 * Adds fleet support for installing alert rule assets from packages behind a feature flag * Alert rule assets should be * updated on subsequent installs * removed when the package is uninstalled * Note tag management for alert rules are done directly on the alert SO. * This is likely to be followed up to switching to an alert rule template saved object instead
…elastic#226085) ## Summary Resolves in part: elastic#221633 Related to: elastic/package-spec#918 * Adds fleet support for installing alert rule assets from packages behind a feature flag * Alert rule assets should be * updated on subsequent installs * removed when the package is uninstalled * Note tag management for alert rules are done directly on the alert SO. * This is likely to be followed up to switching to an alert rule template saved object instead
…elastic#226085) ## Summary Resolves in part: elastic#221633 Related to: elastic/package-spec#918 * Adds fleet support for installing alert rule assets from packages behind a feature flag * Alert rule assets should be * updated on subsequent installs * removed when the package is uninstalled * Note tag management for alert rules are done directly on the alert SO. * This is likely to be followed up to switching to an alert rule template saved object instead
…elastic#226085) ## Summary Resolves in part: elastic#221633 Related to: elastic/package-spec#918 * Adds fleet support for installing alert rule assets from packages behind a feature flag * Alert rule assets should be * updated on subsequent installs * removed when the package is uninstalled * Note tag management for alert rules are done directly on the alert SO. * This is likely to be followed up to switching to an alert rule template saved object instead
|
Temp putting in draft while getting feedback from the alerting team |
💚 Build Succeeded
History
|
|
test integrations |
4 participants
What does this PR do?
Adds support for
alert_rule_templateKibana assetsWhy is it important?
We want to support being able to include prebuilt alert rules in packages, this will help set users up operationally for their agents.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues