Add JSON patch to remove SLO assets for spec versions less than 3.4.0 #884
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "attributes": { | ||
| "name": "Admin Console Availability", | ||
| "description": "", | ||
| "indicator": { | ||
| "type": "sli.kql.custom", | ||
| "params": { | ||
| "index": "kbn-data-forge-fake_stack.admin-console-*", | ||
| "filter": "", | ||
| "good": "http.response.status_code < 500", | ||
| "total": "http.response.status_code : *", | ||
| "timestampField": "@timestamp" | ||
| } | ||
| }, | ||
| "budgetingMethod": "occurrences", | ||
| "timeWindow": { | ||
| "duration": "7d", | ||
| "type": "rolling" | ||
| }, | ||
| "objective": { | ||
| "target": 0.99 | ||
| }, | ||
| "tags": [], | ||
| "groupBy": "url.domain" | ||
| }, | ||
| "id": "good_content-slo-abc-1", | ||
| "references": [], | ||
| "type": "slo" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| format_version: 3.4.0 | ||
| name: good_content | ||
| title: Good content package | ||
| description: > | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| errors: | ||
| exclude_checks: | ||
| - PSR00001 # Allow to use unreleased features in GA package. | ||
|
Comment on lines
+1
to
+3
Contributor
Author
There was a problem hiding this comment. Added since |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be updated the spec version for the compliance test here ?
package-spec/compliance/features/basic.feature
Lines 16 to 19 in 4366bf7
That test is running successfully even if that spec version is not updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the package has SLOs it should be updated, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that spec version is updated to be
@3.4.0, I guess it should be needed to add a new compliance test for3.4.0.Or should it be updated the one with stack
9.1.0-SNAPSHOTto3.4.0? @jsorianopackage-spec/.buildkite/pipeline.trigger.compliance.tests.sh
Line 31 in 4366bf7
Would it be better to create a new content package without SLO , so it can be tested that scenario with previous spec versions
3.3.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new
basic_contenttest package , to be able to keep testing content packages with spec version 3.3.0 (and previous Elastic stacks). Added in 6250bd1