Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for allowed processors in ingest pipelines #586

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 6, 2023

What does this PR do?

Restrict the processors allowed in ingest pipelines.

Why is it important?

Package compatibility with the stack is going to be controlled by the package spec version. Each version of Kibana will support a range of versions of the spec, so the spec needs to be specific about the features each package can use.

Checklist

  • I have added test packages to test/packages that prove my change is effective.
  • I have added an entry in spec/changelog.yml.
  • I have added a condition so this validation is only enabled on v3.

Related issues

@jsoriano jsoriano self-assigned this Sep 6, 2023
@jsoriano
Copy link
Member Author

jsoriano commented Sep 6, 2023

test integrations

@elasticmachine
Copy link

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7682

@elasticmachine
Copy link

💚 Build Succeeded

cc @jsoriano

- version: 3.0.0-next
changes:
- description: Validate processors used in ingest pipelines
type: breaking-change
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasons for this to be breaking:

  • It disallows the use of some processors (that don't seem to be used at the moment).
  • It doesn't support the version parameter in pipelines, but it is not used at the moment in Fleet.

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@jsoriano jsoriano merged commit 450bd34 into elastic:main Sep 7, 2023
1 check passed
@jsoriano jsoriano deleted the validate-pipeline-processors branch September 7, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants