Skip to content

Re-enable validation of duplicated fields #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsoriano wants to merge 2 commits into from
Closed

Re-enable validation of duplicated fields #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520b485
Re-enable validation of duplicated fields
jsoriano May 19, 2022
9e89c82
Merge remote-tracking branch 'origin/main' into enable-check-duplicat…
jsoriano Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions code/go/internal/validator/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ func (s Spec) ValidatePackage(pkg Package) ve.ValidationErrors {
semantic.ValidatePrerelease,
semantic.ValidateFieldGroups,
semantic.ValidateFieldsLimits(rootSpec.Limits.FieldsPerDataStreamLimit),
// Temporarily disabled: https://github.com/elastic/package-spec/issues/331
//semantic.ValidateUniqueFields,
semantic.ValidateUniqueFields,
semantic.ValidateDimensionFields,
semantic.ValidateRequiredFields,
}
Expand Down
1 change: 0 additions & 1 deletion code/go/pkg/validator/validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ func TestValidateVersionIntegrity(t *testing.T) {
}

func TestValidateDuplicatedFields(t *testing.T) {
t.Skip("Validation temporarily disabled: https://github.com/elastic/package-spec/issues/331")
tests := map[string]string{
"bad_duplicated_fields": "field \"event.dataset\" is defined multiple times for data stream \"wrong\", found in: ../../../../test/packages/bad_duplicated_fields/data_stream/wrong/fields/base-fields.yml, ../../../../test/packages/bad_duplicated_fields/data_stream/wrong/fields/ecs.yml",
}
Expand Down
6 changes: 3 additions & 3 deletions versions/1/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
##
- version: 1.11.1-next
changes:
- description: Prepare for next patch release
type: enhancement
link: https://github.com/elastic/package-spec/pull/353
- description: Enable validation of duplicated fields.
type: enhancement
link: https://github.com/elastic/package-spec/pull/338
- version: 1.11.0
changes:
- description: Enable development resources for input packages
Expand Down