-
Notifications
You must be signed in to change notification settings - Fork 91
Add missing properties to fields.yml spec #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
84f656f
Add fields honored by Fleet
andrewkroh e56cc7f
Revert sorting of types
andrewkroh 00c5fa1
Add test to check that asterisk is accepted in field name
andrewkroh afccc99
Disallow additional properties in fields files
andrewkroh b9b5fc1
Remove level, group, title properties from test files
andrewkroh 9295999
Remove include_in_parent, include_in_root
andrewkroh f8fa2ba
Update multi_fields to mention match_only_text
andrewkroh 23bf678
Improve ignore_above description
andrewkroh fc49926
Merge remote-tracking branch 'elastic/main' into fields-yml-spec
andrewkroh ec1318b
Add changelog entry
andrewkroh cb32bb1
Merge remote-tracking branch 'elastic/main' into fields-yml-spec
andrewkroh 116168d
Clarify metric_type and dimension docs
andrewkroh f77a923
Remove match_only_text reference from multi_fields
andrewkroh 2223ec9
Add include_in_parent and include_in_root for nested fields
andrewkroh 81b7637
Set additionalProperties: true
andrewkroh f86db77
Revert "Remove level, group, title properties from test files"
andrewkroh 2baa12c
Amend changelog
andrewkroh 86254fe
Allow dash in field names
andrewkroh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 0 additions & 3 deletions
3
test/packages/bad_deploy_variants/data_stream/foo/fields/fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,7 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 |
3 changes: 0 additions & 3 deletions
3
test/packages/deploy_docker/data_stream/foo/fields/fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,7 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 |
3 changes: 0 additions & 3 deletions
3
test/packages/deploy_terraform/data_stream/foo/fields/fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,7 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 |
6 changes: 0 additions & 6 deletions
6
test/packages/docs_extra_files/data_stream/pe/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,18 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 | ||
| - name: geo.location | ||
| level: core | ||
| type: geo_point | ||
| description: Longitude and latitude. | ||
| - name: geo.region_iso_code | ||
| level: core | ||
| type: keyword | ||
| description: Region ISO code. | ||
| ignore_above: 1024 | ||
| - name: geo.region_name | ||
| level: core | ||
| type: keyword | ||
| description: Region name. | ||
| ignore_above: 1024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
test/packages/good/data_stream/hidden_data_stream/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
test/packages/good/data_stream/ilm_policy/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,18 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 | ||
| - name: geo.location | ||
| level: core | ||
| type: geo_point | ||
| description: Longitude and latitude. | ||
| - name: geo.region_iso_code | ||
| level: core | ||
| type: keyword | ||
| description: Region ISO code. | ||
| ignore_above: 1024 | ||
| - name: geo.region_name | ||
| level: core | ||
| type: keyword | ||
| description: Region name. | ||
| ignore_above: 1024 |
6 changes: 0 additions & 6 deletions
6
test/packages/good/data_stream/skipped_tests/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 0 additions & 6 deletions
6
test/packages/missing_image_files/data_stream/pe/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,18 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 | ||
| - name: geo.location | ||
| level: core | ||
| type: geo_point | ||
| description: Longitude and latitude. | ||
| - name: geo.region_iso_code | ||
| level: core | ||
| type: keyword | ||
| description: Region ISO code. | ||
| ignore_above: 1024 | ||
| - name: geo.region_name | ||
| level: core | ||
| type: keyword | ||
| description: Region name. | ||
| ignore_above: 1024 |
6 changes: 0 additions & 6 deletions
6
test/packages/missing_pipeline_dashes/data_stream/foo/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,18 @@ | ||
| - name: source | ||
| title: Source | ||
| group: 2 | ||
| type: group | ||
| fields: | ||
| - name: geo.city_name | ||
| level: core | ||
| type: keyword | ||
| description: City name. | ||
| ignore_above: 1024 | ||
| - name: geo.location | ||
| level: core | ||
| type: geo_point | ||
| description: Longitude and latitude. | ||
| - name: geo.region_iso_code | ||
| level: core | ||
| type: keyword | ||
| description: Region ISO code. | ||
| ignore_above: 1024 | ||
| - name: geo.region_name | ||
| level: core | ||
| type: keyword | ||
| description: Region name. | ||
| ignore_above: 1024 |
6 changes: 0 additions & 6 deletions
6
test/packages/missing_required_fields/data_stream/foo/fields/some_fields.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Is this an intentional test case? We don't use to have wildcards mixed with suffixes, not sure if everything works as expected with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional to test the
patternspecified forname. It really is an area of unspecified behavior at the moment. I was operating under the assumption that wildcards will be used to implement behavior similar topath_match. But for now this is a test case just to check that the pattern matches fields like this:https://github.com/elastic/integrations/blob/3c88555054fd24a461babebe624d8645b5feea6c/packages/aws/data_stream/cloudwatch_metrics/fields/package-fields.yml#L16
We should refine this area of the spec for dynamic fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could remove the
patternfor now. Then when we get to dynamic fields add it back to match the definition there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, lets leave it. Thanks.