Skip to content

Make all file operations through the filesystem interface#283

Merged
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:filesystem
Feb 23, 2022
Merged

Make all file operations through the filesystem interface#283
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:filesystem

Conversation

@jsoriano
Copy link
Member

What does this PR do?

Migrate all the pending file operations to be done through the filesystem interface.

Why is it important?

This will allow to validate the spec on packages that are stored on any resource for what an implementation of the filesystem interface is available.

This will be also useful to mock filesystems that can be used for testing some scenarios, like the ones needed for #278.

Checklist

  • I have added test packages to test/packages that prove my change is effective. No test added, but as a refactor I focused on making the current ones pass.
  • I have added an entry in versions/N/changelog.yml. No user facing change.

Related issues

@jsoriano jsoriano requested a review from a team as a code owner February 23, 2022 11:16
@jsoriano jsoriano self-assigned this Feb 23, 2022
@elasticmachine
Copy link

elasticmachine commented Feb 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-23T15:28:02.688+0000

  • Duration: 4 min 21 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

mtojek
mtojek previously approved these changes Feb 23, 2022
@jsoriano
Copy link
Member Author

@mtojek sorry, I have just pushed a function to validate zips, happy to move this to a different PR, I only wanted to try this with a different implementation of fs.FS.

@mtojek mtojek self-requested a review February 23, 2022 16:21
@jsoriano jsoriano merged commit 0227d87 into elastic:main Feb 23, 2022
@jsoriano jsoriano deleted the filesystem branch February 23, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants