Make all file operations through the filesystem interface#283
Merged
jsoriano merged 3 commits intoelastic:mainfrom Feb 23, 2022
Merged
Make all file operations through the filesystem interface#283jsoriano merged 3 commits intoelastic:mainfrom
jsoriano merged 3 commits intoelastic:mainfrom
Conversation
jsoriano
commented
Feb 23, 2022
mtojek
previously approved these changes
Feb 23, 2022
Member
Author
|
@mtojek sorry, I have just pushed a function to validate zips, happy to move this to a different PR, I only wanted to try this with a different implementation of |
2 tasks
mtojek
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate all the pending file operations to be done through the filesystem interface.
Why is it important?
This will allow to validate the spec on packages that are stored on any resource for what an implementation of the filesystem interface is available.
This will be also useful to mock filesystems that can be used for testing some scenarios, like the ones needed for #278.
Checklist
test/packagesthat prove my change is effective. No test added, but as a refactor I focused on making the current ones pass.versions/N/changelog.yml. No user facing change.Related issues