Skip to content

Support ML module Kibana type #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgowdyelastic merged 6 commits into from
Mar 24, 2021
Merged

Support ML module Kibana type #152

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e89676f
Support ML module Kibana type
jgowdyelastic Mar 18, 2021
6e4a096
updating changelog
jgowdyelastic Mar 18, 2021
843283b
update after running make update
jgowdyelastic Mar 22, 2021
92fab43
renaming folder
jgowdyelastic Mar 23, 2021
05395ed
adding example module file
jgowdyelastic Mar 23, 2021
58f8cb6
Merge remote-tracking branch 'origin/master' into add-support-for-ml-…
jgowdyelastic Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/go/internal/spec/statik.go
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions test/packages/good/kibana/ml/good-ml-module-abc-1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}

@ruflin ruflin Mar 22, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have some example content, mostly to see how it will look and as an example.

@jgowdyelastic jgowdyelastic Mar 23, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the NGINX module saved object in 05395ed

3 changes: 3 additions & 0 deletions versions/1/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,6 @@
- description: Add kibana/security-rule asset
type: enhancement
link: https://github.com/elastic/package-spec/pull/142
- description: Support `ML module` Kibana type.
type: enhancement
link: https://github.com/elastic/package-spec/pull/152
9 changes: 9 additions & 0 deletions versions/1/kibana/spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,12 @@
type: file
contentMediaType: "application/json"
pattern: '^.+\.json$'
- description: Folder containing ML module assets
type: folder
name: ml_module

@ycombinator ycombinator Mar 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test package, I assume you want the folder under kibana/ to be named ml/?

Suggested change
name: ml_module
name: ml

@ruflin ruflin Mar 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the folder should be under kibana but named ml_module. There might be other ML assets in the future.

@jgowdyelastic jgowdyelastic Mar 23, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a mistake. The changes I had made to test elastic/kibana#94950 use ml_module
Updated in 92fab43

required: false
contents:
- description: An ML module asset file
type: file
contentMediaType: "application/json"
pattern: '^{PACKAGE_NAME}-.+\.json$'