Skip to content

Remove pipeline test config json #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ycombinator merged 5 commits into from
Mar 17, 2021
Merged

Remove pipeline test config json #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5508af4
Removing deprecated items
ycombinator Mar 16, 2021
9a503de
Updating spec
ycombinator Mar 16, 2021
9468c4f
Add CHANGELOG entry
ycombinator Mar 16, 2021
de13bb2
Removing file that is no longer allowed by the spec
ycombinator Mar 16, 2021
46f059a
Forgot to remove another test file that is no longer allowed
ycombinator Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/go/internal/spec/statik.go
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 0 additions & 14 deletions test/packages/expanded/data_stream/foo/_dev/test/pipeline/test-access-raw.log-config.json
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions test/packages/good/data_stream/foo/_dev/test/pipeline/test-access-event.json-config.json
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion versions/1/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,7 @@
link: https://github.com/elastic/package-spec/pull/143
- description: Pipeline test results can be optional
type: enhancement
link: https://github.com/elastic/package-spec/pull/147
link: https://github.com/elastic/package-spec/pull/147
- description: Remove deprecated JSON-formatted pipeline test configs
type: breaking-change
link: https://github.com/elastic/package-spec/pull/150
18 changes: 2 additions & 16 deletions versions/1/data_stream/_dev/test/pipeline/spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,13 @@ spec:
type: file
pattern: '^test-[a-z0-9-]+\.log$'
required: false
- description: JSON-formatted configuration for a test case in raw format
type: file
pattern: '^test-[a-z0-9-]+\.log-config.json$'
contentMediaType: "application/json"
required: false
deprecated: true # use "YAML-formatted configuration for a test case in raw format"
$ref: "./config_raw.spec.yml"
- description: JSON-formatted configuration for a test case in JSON format
type: file
pattern: '^test-[a-z0-9-]+\.json-config.json$'
contentMediaType: "application/json"
required: false
deprecated: true # use "YAML-formatted configuration for a test case in JSON format"
$ref: "./config_json.spec.yml"
- description: YAML-formatted configuration for a test case in raw format
- description: Configuration for a test case in raw format
type: file
pattern: '^test-[a-z0-9-]+\.log-config.yml'
contentMediaType: "application/x-yaml"
required: false
$ref: "./config_raw.spec.yml"
- description: YAML-formatted configuration for a test case in JSON format
- description: Configuration for a test case in JSON format
type: file
pattern: '^test-[a-z0-9-]+\.json-config.yml'
contentMediaType: "application/x-yaml"
Expand Down