Skip to content

Add support for inputs with qualified names#1135

Merged
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:qualified-input-name
Apr 13, 2026
Merged

Add support for inputs with qualified names#1135
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:qualified-input-name

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Apr 9, 2026

What does this PR do?

Add support for inputs with qualified names. See fleet implementation in elastic/kibana#262138.

This field aims to fix cases of multiple inputs of the same type in policy templates, what starts being common with otelcol. In these cases a name can be used to explicitly correlate inputs in data streams.

Why is it important?

With the introduction of OTel integrations in 3.6 it starts to be common having multiple inputs with the same type in the same policy template. This leads to ambiguous situations, as data streams referring to these inputs by type cannot distinguish between them.

Checklist

Related issues

@jsoriano jsoriano self-assigned this Apr 9, 2026
@jsoriano jsoriano requested a review from a team as a code owner April 9, 2026 10:13
@jsoriano jsoriano force-pushed the qualified-input-name branch from 7f61bae to 4649d26 Compare April 9, 2026 10:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf4302bd-82aa-4416-9593-97766fea5150

📥 Commits

Reviewing files that changed from the base of the PR and between f52133b and 53cdb09.

📒 Files selected for processing (1)
  • spec/changelog.yml
✅ Files skipped from review due to trivial changes (1)
  • spec/changelog.yml

📝 Walkthrough

Walkthrough

Adds a semantic validator that reads manifest.yml and enforces that when a policy_template contains multiple inputs with the same type, each such input must have a non-empty name. Violations produce a structured validation error (code SVR00010). Introduces the name property to the integration inputs schema, registers the validator in the semantic pipeline for integrations, and adds tests, test fixtures, and changelog/documentation updates.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@jsoriano jsoriano force-pushed the qualified-input-name branch from 4649d26 to f52133b Compare April 9, 2026 10:15
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @jsoriano

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Apr 9, 2026

test integrations

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Created or updated PR in integrations repository to test this version. Check elastic/integrations#18309

{fn: semantic.ValidateKibanaTagDuplicates},
{fn: semantic.ValidatePipelineOnFailure, types: []string{"integration"}, since: semver.MustParse("3.6.0")},
{fn: semantic.ValidateIntegrationInputsDeprecation, types: []string{"integration"}, since: semver.MustParse("3.6.0")},
{fn: semantic.ValidateIntegrationInputQualifier, types: []string{"integration"}, since: semver.MustParse("3.6.0")},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be 3.6.1?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to allow this from 3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants