Add support for inputs with qualified names#1135
Conversation
7f61bae to
4649d26
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a semantic validator that reads manifest.yml and enforces that when a policy_template contains multiple inputs with the same type, each such input must have a non-empty name. Violations produce a structured validation error (code SVR00010). Introduces the name property to the integration inputs schema, registers the validator in the semantic pipeline for integrations, and adds tests, test fixtures, and changelog/documentation updates. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4649d26 to
f52133b
Compare
💚 Build Succeeded
cc @jsoriano |
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#18309 |
| {fn: semantic.ValidateKibanaTagDuplicates}, | ||
| {fn: semantic.ValidatePipelineOnFailure, types: []string{"integration"}, since: semver.MustParse("3.6.0")}, | ||
| {fn: semantic.ValidateIntegrationInputsDeprecation, types: []string{"integration"}, since: semver.MustParse("3.6.0")}, | ||
| {fn: semantic.ValidateIntegrationInputQualifier, types: []string{"integration"}, since: semver.MustParse("3.6.0")}, |
There was a problem hiding this comment.
I would like to allow this from 3.6.0.
What does this PR do?
Add support for inputs with qualified names. See fleet implementation in elastic/kibana#262138.
This field aims to fix cases of multiple inputs of the same type in policy templates, what starts being common with
otelcol. In these cases anamecan be used to explicitly correlate inputs in data streams.Why is it important?
With the introduction of OTel integrations in 3.6 it starts to be common having multiple inputs with the same type in the same policy template. This leads to ambiguous situations, as data streams referring to these inputs by type cannot distinguish between them.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues