Skip to content

[CI] Use gvm on Windows to install Golang#1116

Merged
mrodm merged 3 commits intoelastic:mainfrom
mrodm:update_windows_ci
Mar 16, 2026
Merged

[CI] Use gvm on Windows to install Golang#1116
mrodm merged 3 commits intoelastic:mainfrom
mrodm:update_windows_ci

Conversation

@mrodm
Copy link
Copy Markdown
Contributor

@mrodm mrodm commented Mar 13, 2026

What does this PR do?

  • Replace Chocolatey-based Golang installation with GVM in the Windows CI script, matching the approach used in Linux steps and already adopted in [CI] Use gvm on windows to install Golang package-registry#1617.
  • Remove the hardcoded GO_VERSION: "1.24.6" override from the Windows pipeline step, since GVM can install any Go version (including versions not available in Chocolatey).

Why is it important?

Chocolatey does not always have the latest Golang versions available (e.g. 1.25.8), which forced the Windows CI step to pin an older version. Using GVM eliminates this limitation and keeps the Windows installation approach consistent with Linux.

Checklist

  • I have added test packages to test/packages that prove my change is effective.
  • I have added an entry in spec/changelog.yml.
  • Verify Buildkite Windows CI step installs Go successfully via GVM.
  • Confirm the installed Go version matches .go-version (1.25.8).
  • Confirm all unit tests pass on the Windows step.

Related issues


Generated with the assistance of Cursor

@mrodm mrodm changed the title Update windows ci [CI] Use gvm on Windows to install Golang Mar 13, 2026
@mrodm mrodm self-assigned this Mar 13, 2026
Comment on lines -38 to -40
env:
# Latest 1.24 version supported by Chocolatey.
GO_VERSION: "1.24.6"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this step will run the Golang version defined in .go-version file.

@mrodm mrodm marked this pull request as ready for review March 13, 2026 17:24
@mrodm mrodm requested a review from a team as a code owner March 13, 2026 17:24
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @mrodm

@mrodm mrodm merged commit aac1e57 into elastic:main Mar 16, 2026
3 checks passed
@mrodm mrodm deleted the update_windows_ci branch March 16, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants