-
Notifications
You must be signed in to change notification settings - Fork 90
Otel profiles input package support #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
23426b0
Add new index settings support for profiling
MichelLosier 9d94633
Add profiles policy template type for input packages
MichelLosier eba953e
Add good_input_profiles test
MichelLosier 2edb3aa
Add PR links to changelogs
MichelLosier 9368c6a
Use 'profiling' policy template type, instead of 'profiles'
MichelLosier 7db0020
Undo formatting changes
MichelLosier a07acf3
Add support for 'profiles' type for input package policy_templates
MichelLosier 2b46b0e
Rework good_input_profiles test package and start compliance test
MichelLosier a80f568
Add JSON patch for profiles input policy template type support below …
MichelLosier ca6edba
Add good_input_profiles to validator, remove fields def, change to no…
MichelLosier b8b7421
Remove index_template assertion for good_input_profiles compliance test
MichelLosier 3b4915b
Remove elasticsearch config from good_input_profiles manifest
MichelLosier 333d035
Fix formatting
MichelLosier 95a9604
Fix removal of profiles enum for < 3.6.0 spec
MichelLosier 039b78f
Update manifest spec to require input otelcol for profiles type
MichelLosier e8ce919
Fix allOf rule positioning, update json patch
MichelLosier 41a6391
Add bad_input_profiles_non_otel test package
MichelLosier 2c42d1b
Adjust location of profiles otelcol constraint in spec
MichelLosier 6dae359
Merge branch 'main' into profiling-support
MichelLosier 14b16e5
Add compliance test scenario for expected otel pipeline in input temp…
MichelLosier 81638ee
Add comment for MustExistInputTemplateWithOtelPipeline
MichelLosier 68f58af
Formatting
MichelLosier 5997fa8
Revert input templates compliance test
MichelLosier c5cee93
Revert small format changes
MichelLosier fddc7c4
Merge branch 'main' into profiling-support
MichelLosier 263a6e3
Add comment in compliance test about why we don't assert on es assets…
MichelLosier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
test/packages/bad_input_profiles_non_otel/agent/input/input.yml.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| receivers: | ||
| profiling: | ||
| {{#if samples_per_second}} | ||
| samples_per_second: {{samples_per_second}} | ||
| {{/if}} | ||
|
|
||
| service: | ||
| pipelines: | ||
| profiles: | ||
| receivers: [ profiling ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| - version: 0.0.1 | ||
| changes: | ||
| - type: enhancement | ||
| description: Initial release for testing input policy templates with type `profiles` with a non otelcol input type. | ||
| link: https://github.com/elastic/package-spec/pull/1092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This is a template for the package README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| format_version: 3.6.0 | ||
| name: bad_input_profiles_non_otel | ||
| title: "Bad OpenTelemetry Profiling" | ||
| version: 0.0.1 | ||
| source: | ||
| license: "Elastic-2.0" | ||
| description: "Bad OpenTelemetry Profiling" | ||
| type: input | ||
| categories: | ||
| - custom | ||
| - observability | ||
| - opentelemetry | ||
| conditions: | ||
| kibana: | ||
| version: "^9.4.0" | ||
| elastic: | ||
| subscription: "basic" | ||
| policy_templates: | ||
| - name: profilingreceiver | ||
| type: profiles | ||
| title: OpenTelemetry Profiling receiver | ||
| description: Collect profiling data | ||
| input: logs | ||
| template_path: input.yml.hbs | ||
| vars: | ||
| - name: samples_per_second | ||
| type: integer | ||
| required: false | ||
| description: Defines the sampling frequency. | ||
| owner: | ||
| github: elastic/ingest-otel-data | ||
| type: elastic |
10 changes: 10 additions & 0 deletions
10
test/packages/good_input_profiles/agent/input/input.yml.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| receivers: | ||
| profiling: | ||
| {{#if samples_per_second}} | ||
| samples_per_second: {{samples_per_second}} | ||
| {{/if}} | ||
|
|
||
| service: | ||
| pipelines: | ||
| profiles: | ||
| receivers: [ profiling ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| - version: 0.0.1 | ||
| changes: | ||
| - type: enhancement | ||
| description: Initial release for testing input policy templates with type `profiles`. | ||
| link: https://github.com/elastic/package-spec/pull/1092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| This is a template for the package README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| format_version: 3.6.0 | ||
| name: good_input_profiles | ||
| title: "OpenTelemetry Profiling" | ||
| version: 0.0.1 | ||
| source: | ||
| license: "Elastic-2.0" | ||
| description: "OpenTelemetry Profiling" | ||
| type: input | ||
| categories: | ||
| - custom | ||
| - observability | ||
| - opentelemetry | ||
| conditions: | ||
| kibana: | ||
| version: "^9.4.0" | ||
| elastic: | ||
| subscription: "basic" | ||
| policy_templates: | ||
| - name: profilingreceiver | ||
| type: profiles | ||
| title: OpenTelemetry Profiling receiver | ||
| description: Collect profiling data | ||
| input: otelcol | ||
| template_path: input.yml.hbs | ||
| vars: | ||
| - name: samples_per_second | ||
| type: integer | ||
| required: false | ||
| description: Defines the sampling frequency. | ||
| owner: | ||
| github: elastic/ingest-otel-data | ||
| type: elastic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.