Encode fields in Kibana objects if not encoded#506
Merged
mtojek merged 3 commits intoelastic:masterfrom Jun 10, 2020
Merged
Conversation
ruflin
approved these changes
Jun 10, 2020
Collaborator
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Seems like the tests show that if it is decoded, encoding still works as not generated files were updated. Lets hope the other part also works ;-)
| "pod": "kubernetes.pod.uid", | ||
| "tiebreaker": "_doc", | ||
| "timestamp": "@timestamp" | ||
| "infrastructure-ui-source" : { |
Collaborator
There was a problem hiding this comment.
I wonder why it reordered this one 🤔
Contributor
Author
There was a problem hiding this comment.
Accidentally cleaned up the source here. There are no differences in the content.
💚 Build Succeeded
Expand to view the summary
Build stats
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #466 (comment)
This PR modifies the generator code to encode fields that are not encoded. If they are encoded, it leaves them as is.