[Endpoint] Adding image and fixing inputs#260
[Endpoint] Adding image and fixing inputs#260jonathan-buttner merged 3 commits intoelastic:masterfrom
Conversation
ruflin
left a comment
There was a problem hiding this comment.
LGTM
I'm not covinced that the endpoint package will have to specify inputs in the end but it works for now.
|
Thanks for the review, yeah I agree, I had to do this because the UI was throwing an error here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/step_configure_datasource.tsx#L188 @jfsiii @jen-huang I had to add this to the manifest: otherwise the I think the UI was failing to find the |
|
@jonathan-buttner I'll add some additional safeguards here. Thanks! |
|
PR that adds more null checks: elastic/kibana#60426 |
|
Awesome thanks @jen-huang I'm testing it right now and then I'll 👍 |
This PR adds an image and some inputs so the kibana UI doesn't fail when installing the package.