Skip to content

Comments

[Endpoint] Adding image and fixing inputs#260

Merged
jonathan-buttner merged 3 commits intoelastic:masterfrom
jonathan-buttner:placeholder-inputs
Mar 17, 2020
Merged

[Endpoint] Adding image and fixing inputs#260
jonathan-buttner merged 3 commits intoelastic:masterfrom
jonathan-buttner:placeholder-inputs

Conversation

@jonathan-buttner
Copy link
Contributor

This PR adds an image and some inputs so the kibana UI doesn't fail when installing the package.

Copy link
Collaborator

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm not covinced that the endpoint package will have to specify inputs in the end but it works for now.

@jonathan-buttner jonathan-buttner marked this pull request as ready for review March 17, 2020 15:47
@jonathan-buttner
Copy link
Contributor Author

Thanks for the review, yeah I agree, I had to do this because the UI was throwing an error here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/step_configure_datasource.tsx#L188

@jfsiii @jen-huang I had to add this to the manifest:

    inputs:
      - type: metrics
      - type: events

https://github.com/elastic/package-registry/pull/260/files#diff-381ba165569ba08ab0eb43fc21b4cb66R22

otherwise the I think the UI was failing to find the packageInfo.datasources[0].inputs. Would it make sense to add inputs to the check as well?
Something like:
packageInfo.datasources && packageInfo.datasources[0] && packageInfo.datasources[0].input

@jen-huang
Copy link
Contributor

@jonathan-buttner I'll add some additional safeguards here. Thanks!

@jen-huang
Copy link
Contributor

PR that adds more null checks: elastic/kibana#60426

@jonathan-buttner
Copy link
Contributor Author

Awesome thanks @jen-huang I'm testing it right now and then I'll 👍

@jonathan-buttner jonathan-buttner changed the title [WIP] [Endpoint] Adding image and fixing inputs [Endpoint] Adding image and fixing inputs Mar 17, 2020
@jonathan-buttner jonathan-buttner merged commit fa4ceb2 into elastic:master Mar 17, 2020
@jonathan-buttner jonathan-buttner deleted the placeholder-inputs branch March 17, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants