-
Notifications
You must be signed in to change notification settings - Fork 80
Prepare 1.37.0 #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Prepare 1.37.0 #1613
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b8b145d
Update Go version to 1.26.1 and document in CHANGELOG for release 1.37.0
teresaromero fb615c0
Update CHANGELOG to reflect PR
teresaromero 73d3531
Downgrade Go version from 1.26.1 to 1.25.8 in .go-version file
teresaromero 7e053ac
Update CHANGELOG
teresaromero f1c1761
Update Golang installation script to default to version 1.25.7 for sp…
teresaromero 96b7848
Merge branch 'main' of github.com:elastic/package-registry into prepa…
teresaromero a4d46d8
fix latest_1_25_versions
teresaromero 1fa2200
Bump version to 1.37.0 in main.go and index.json
teresaromero bc88a8b
Apply suggestion from @mrodm
teresaromero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.25.7 | ||
| 1.26.1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use for now Golang 1.25.8.
We also have the go.mod that sets
go 1.25.0https://github.com/elastic/package-spec/blob/3e48996fb4c8a34ef105b0487fe689b8ab69000f/go.mod#L3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vulnerabilities are fixed at 1.26.1, shall we update all to 1.26 then or not fix them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake, i was running with 1.26. changing to 1.25.8