Skip to content

[receiver/elasticapm]Fix benchmarks to produce correct IDs#1235

Merged
lahsivjar merged 1 commit into
elastic:mainfrom
lahsivjar:minor-fixes
May 26, 2026
Merged

[receiver/elasticapm]Fix benchmarks to produce correct IDs#1235
lahsivjar merged 1 commit into
elastic:mainfrom
lahsivjar:minor-fixes

Conversation

@lahsivjar

Copy link
Copy Markdown
Contributor

Fix a few remaining issues from #1214

@lahsivjar lahsivjar requested review from a team as code owners May 26, 2026 17:36
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 2dab8b65-aaf7-4d35-b6cc-379ff095b913

📥 Commits

Reviewing files that changed from the base of the PR and between 6937934 and a4c6568.

📒 Files selected for processing (2)
  • receiver/elasticapmintakereceiver/receiver_bench_test.go
  • receiver/elasticapmintakereceiver/resource_grouping.go

📝 Walkthrough

Walkthrough

This PR refactors the mixed-workload benchmark's synthetic ID generation to use zero-padded hex formatting (e.g., %016x, %032x) derived from numeric sequences instead of prefixed patterns, and updates the resource fingerprinting comment to clarify that the computation depends on deterministic attribute visitation order while the key inclusion prevents value-sequence ambiguity.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lahsivjar lahsivjar merged commit 49e63fa into elastic:main May 26, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants