[process/elasticapmprocessor] enable service language attribute processing for traces#1151
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughEnabled ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
carsonip
left a comment
There was a problem hiding this comment.
populate the default service name for otlp ecs
q: isn't this PR around telemetry.sdk.language?
| intakeECSEnricherConfig.Transaction.Result.Enabled = false | ||
| // The `host.os.type` field should not be added for APM events | ||
| intakeECSEnricherConfig.Resource.HostOSType.Enabled = false | ||
| intakeECSEnricherConfig.Resource.DefaultServiceLanguage.Enabled = false |
There was a problem hiding this comment.
sorry I don't have much context. What does it mean to enable it for ecs enricher but not intake ecs enricher?
There was a problem hiding this comment.
is the effect of this PR to enable default service language for otlp ecs path but not intake ecs path?
There was a problem hiding this comment.
Yes, I saw it was done for the log event and potentially for the metrics event in #1122 and followed the same pattern.
From what I understood from the code, I think this is done so that we do not set a default language for apm events. That's what I understood from intake receiver mapping.
So in this context, we would only add the default service language for otlp ecs path.
There was a problem hiding this comment.
I can add a comment so it is clearer for the next reader
There was a problem hiding this comment.
We can consider dedicated methods to build each class of configs (otlp ecs vs intake ecs) if the drift gets more significant
Sorry I should have added that in the pr body but we need to populate |
I see, so it is about service language name, not service name. |
…ed in intakeECSEnricher
Summary
trace events currently do not populate the default service name for otlp ecs. This PR fixes that by enabling the enricher
DefaultServiceLanguageflagWe need to set the field
telemetry.sdk.languageso that our exporter would map it toservice.language.nameTests