Change agent pprof default to false #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
docs
4 tasks
|
A documentation preview will be available soon: |
Contributor
Author
|
I'll need to backport to |
dedemorton
reviewed
Nov 30, 2021
Contributor
dedemorton
left a comment
dedemorton
left a comment
There was a problem hiding this comment.
A few minor fixes. Otherwise looks good. Thanks for updating the docs!
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: DeDe Morton <[email protected]>
dedemorton
approved these changes
Nov 30, 2021
michel-laterman
added a commit
to michel-laterman/observability-docs
that referenced
this pull request
Nov 30, 2021
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
michel-laterman
added a commit
to michel-laterman/observability-docs
that referenced
this pull request
Nov 30, 2021
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
michel-laterman
added a commit
that referenced
this pull request
Nov 30, 2021
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
michel-laterman
added a commit
that referenced
this pull request
Nov 30, 2021
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/observability-docs
that referenced
this pull request
Apr 11, 2023
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in elastic/beats#29108 we will be changing the default
agent.monitoring.pprofoption to false.Behaviour of the option has also slightly changed to also apply to beats that the agent runs: elastic/beats#29155