Skip to content

Fix Docker install and require the 'stdio' CLI parameter #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

Fix Docker install and require the 'stdio' CLI parameter #97

merged 3 commits into from
Jun 18, 2025

Conversation

@swallez
Copy link
Contributor

@swallez swallez commented Jun 17, 2025 •
edited
Loading

  • Require the stdio CLI parameter when running as a container. This is to future-proof the addition of the http protocol that will require the http parameter.
  • Refactor Docker file do make it build cache friendly
  • Fix OTel configuration so that it doesn't pollute stdout that's used to communicate with the client
  • Build a multi-arch (amd64 and arm64) using npm run build-docker-image
  • Update README and CONTRIBUTING to include instructions for the Docker image

Tested with Claude and Goose (still need automated validation tests)

@swallez swallez marked this pull request as ready for review June 18, 2025 13:17
@swallez swallez requested a review from a team as a code owner June 18, 2025 13:17
@swallez swallez merged commit 12946ec into main Jun 18, 2025
2 checks passed
@swallez swallez deleted the add-stdio-cli branch June 18, 2025 14:59
@swallez swallez mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swallez @Anaethelion