-
Notifications
You must be signed in to change notification settings - Fork 3.5k
metrics: add gauge with compression goal if enabled #18230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @yaauie? 🙏
|
| super().dup.tap do |overrides| | ||
| overrides['pipeline.id'] = pipeline_id | ||
| if logstash_service.settings.feature_flag == "persistent_queues" | ||
| overrides['queue.compression'] = %w(none speed balanced size).sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the decision to sample the available values instead of exploding the matrix by 4x.
97c18bc to
8b1da6d
Compare
robbavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
💛 Build succeeded, but was flaky
Failed CI Steps |





Release notes
[rn: skip]
What does this PR do?
Adds a gauge to pipeline queue compression metrics to indicate the encode goal
Why is it important/What is the impact to the user?
When a user is analyzing the cost and benefit of queue compression, including the current setting helps contextualize the values.
Checklist
[ ] I have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
example-input.ndjson:feedutility to your pathencode.goalmatches the providedqueue.compressionsetting.Related issues
Pared off of: #18227
Use cases
Screenshots
Logs