Refactor/rspec #1758

electrical · 2014-09-21T13:38:22Z

First step of the Rspec refactoring for #1737

elasticsearch-release · 2014-09-21T13:44:16Z

🔴 Test failed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/114/

elasticsearch-release · 2014-09-21T16:34:14Z

🔴 Test failed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/115/

elasticsearch-release · 2014-09-21T16:39:19Z

🔴 Test failed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/116/

elasticsearch-release · 2014-09-21T18:31:33Z

🔴 Test failed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/117/

elasticsearch-release · 2014-09-22T10:45:05Z

🔴 Test failed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/118/

elasticsearch-release · 2014-09-22T11:50:20Z

💚 Test passed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/119/

jordansissel · 2014-09-22T18:22:55Z

spec/core/conditionals_spec.rb

jordansissel · 2014-09-22T18:27:47Z

Did a quick review. Overall LGTM. I will test.

elasticsearch-release · 2014-09-22T19:25:18Z

💚 Test passed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/121/

jordansissel · 2014-09-29T17:22:26Z

spec/support/LOGSTASH-733.rb

Any reason these regression tests were removed?

All tests were either duplicate ( already present in the actual spec file ) or i've merged them together in the spec file of the filter it self.

jordansissel · 2014-09-29T17:23:29Z

LGTM except for my comment about regression test removal

jordansissel · 2014-09-29T18:20:39Z

LGTM.

jordansissel · 2014-09-29T22:28:10Z

@electrical can you rebase this against master?

- Move helper functions in own modules and extend Rspec - Refactor files into correct naming and paths - Modify files to use new spec_helper and helpers - Pin rspec to 2.14.x

- date speed test only run when performance is enabled

When doing randomized testing, one of the tests failed because kafka was not initialized yet

jordansissel · 2014-09-30T15:11:41Z

(break == many PRs have tests, I think this may break merges, but it's the right change so we'll just have to step up some PR help to compensate)

electrical · 2014-09-30T15:12:49Z

Allot of PR's will need to be directed to the individual repo's anyway when im done with that ( soon )

jordansissel · 2014-09-30T15:23:52Z

+1

wiibaa · 2014-09-30T15:24:01Z

@jordansissel talking about the split to individual repos, will you share a magic github-octokit command to easily watch them all ??

jordansissel · 2014-09-30T15:27:25Z

@wiibaa yeah we'll publish something to do that.

Fixes #1758

- date speed test only run when performance is enabled Fixes #1758

Fixes #1758

When doing randomized testing, one of the tests failed because kafka was not initialized yet Fixes #1758

Fixes #1758

- Move helper functions in own modules and extend Rspec - Refactor files into correct naming and paths - Modify files to use new spec_helper and helpers - Pin rspec to 2.14.x Fixes #1758

Fixes #1758

- date speed test only run when performance is enabled Fixes #1758

Fixes #1758

When doing randomized testing, one of the tests failed because kafka was not initialized yet Fixes #1758

Fixes #1758

colinsurprenant · 2014-09-30T18:05:37Z

post-merge LGTM ;) Good job!

jordansissel added the O(6) label Sep 22, 2014

jordansissel reviewed Sep 22, 2014
View reviewed changes

spec/core/conditionals_spec.rb Outdated

Copy link

Contributor

jordansissel Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss!

jordansissel force-pushed the master branch from f86287d to a536eef Compare September 27, 2014 04:57

electrical added needreview enhancement labels Sep 29, 2014

electrical self-assigned this Sep 29, 2014

jordansissel reviewed Sep 29, 2014
View reviewed changes

Richard Pijnenburg added 7 commits September 30, 2014 09:29

[RSPEC] Refactoring step 1

4b6044e

- Move helper functions in own modules and extend Rspec - Refactor files into correct naming and paths - Modify files to use new spec_helper and helpers - Pin rspec to 2.14.x

Update gitignore file

cc29f38

Add missing tests

b8a56bb

An other missing one

9156e43

Fix performance tests

756a7c7

- date speed test only run when performance is enabled

[TESTING] Fix tcp input spec test

fbbeb08

[TESTING] Fix Kafka output test

cd1f09b

When doing randomized testing, one of the tests failed because kafka was not initialized yet

jordansissel added the 1.x label Sep 30, 2014

electrical closed this in 51b3bf4 Sep 30, 2014

electrical pushed a commit that referenced this pull request Sep 30, 2014

Update gitignore file

17e282c

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Add missing tests

46a6e78

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

An other missing one

58f6bad

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Fix performance tests

ef23308

- date speed test only run when performance is enabled Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

[TESTING] Fix tcp input spec test

42fa9ea

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

[TESTING] Fix Kafka output test

6daeb22

When doing randomized testing, one of the tests failed because kafka was not initialized yet Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Minor fixes after review

79c4802

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

[TESTING] Convert ruby filter spec after rebase

cf22421

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Update gitignore file

7d64c1e

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Add missing tests

3bf6de9

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

An other missing one

1274034

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Fix performance tests

bb583bd

- date speed test only run when performance is enabled Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

[TESTING] Fix tcp input spec test

7732d22

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

[TESTING] Fix Kafka output test

e7d41e3

When doing randomized testing, one of the tests failed because kafka was not initialized yet Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

Minor fixes after review

98583e5

Fixes #1758

electrical pushed a commit that referenced this pull request Sep 30, 2014

[TESTING] Convert ruby filter spec after rebase

54cb320

Fixes #1758

colinsurprenant added the v1.x label Oct 6, 2014

jordansissel added this to the v1.5.0 milestone Nov 11, 2014

electrical deleted the refactor/rspec branch December 16, 2014 15:41

wiibaa mentioned this pull request Mar 3, 2015

Logstash 1.4.2 unit tests fail in 1.5.0 beta1 version #2743

Closed

electrical removed their assignment Feb 20, 2016

Refactor/rspec #1758

Refactor/rspec #1758

Uh oh!

Conversation

electrical commented Sep 21, 2014

Uh oh!

elasticsearch-release commented Sep 21, 2014

Uh oh!

elasticsearch-release commented Sep 21, 2014

Uh oh!

elasticsearch-release commented Sep 21, 2014

Uh oh!

elasticsearch-release commented Sep 21, 2014

Uh oh!

elasticsearch-release commented Sep 22, 2014

Uh oh!

elasticsearch-release commented Sep 22, 2014

Uh oh!

jordansissel Sep 22, 2014

Choose a reason for hiding this comment

Uh oh!

jordansissel commented Sep 22, 2014

Uh oh!

elasticsearch-release commented Sep 22, 2014

Uh oh!

jordansissel Sep 29, 2014

Choose a reason for hiding this comment

Uh oh!

electrical Sep 29, 2014

Choose a reason for hiding this comment

Uh oh!

jordansissel commented Sep 29, 2014

Uh oh!

jordansissel commented Sep 29, 2014

Uh oh!

jordansissel commented Sep 29, 2014

Uh oh!

jordansissel commented Sep 30, 2014

Uh oh!

electrical commented Sep 30, 2014

Uh oh!

jordansissel commented Sep 30, 2014

Uh oh!

wiibaa commented Sep 30, 2014

Uh oh!

jordansissel commented Sep 30, 2014

Uh oh!

colinsurprenant commented Sep 30, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants