-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Release notes for 8.17.5 #17550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 8.17.5 #17550
Conversation
mashhurs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| ==== Plugin releases | ||
| Plugins align with release 7.14.0 | ||
| Plugins align with release 7.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 what is this 7.14.0? Shouldn't be 8.0.0 (initial 8)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is at the very bottom of the 8.x release notes file, and aligns with Logstash 8.0.0-alpha release notes.
|
|
||
| ==== Plugins | ||
|
|
||
| *Elasticsearch Filter - 3.17.1* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
karenzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left suggestion and notes inline. Otherwise, LGTM!
Thanks for your work on this, @donoghuc
Please merge by end of day on the day before the release.
|
|
||
| ==== Plugin releases | ||
| Plugins align with release 7.14.0 | ||
| Plugins align with release 7.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is at the very bottom of the 8.x release notes file, and aligns with Logstash 8.0.0-alpha release notes.
| [[logstash-8-17-5]] | ||
| === Logstash 8.17.5 Release Notes | ||
|
|
||
| * The `SettingString` setting is now correctly non-nullable and `SettingNullableString` is nullable. https://github.com/elastic/logstash/pull/17522[#17522] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out "Release notes" section in the PR. The developers put suggestions for user-focused release notes there, and they're usually more informative than the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i had seen that but it didnt quite make sense to me so I tried to make it a bit more explicit. Would you prefer that just gets copied over?
Ensures that SettingString is correctly non-nullable and SettingNullableString is nullable. https://github.com/elastic/logstash/pull/17522[#17522]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donoghuc You make the call. I trust your judgement. :-)
Co-authored-by: Karen Metts <[email protected]>
|
@mergify backport 8.x |
✅ Backports have been createdDetails
|
* Update release notes for 8.17.5 * Filter out non-user facing commits/changes from release notes * Update based on PR review Co-authored-by: Karen Metts <[email protected]> --------- Co-authored-by: logstashmachine <[email protected]> Co-authored-by: donoghuc <[email protected]> Co-authored-by: Karen Metts <[email protected]> (cherry picked from commit 16ee40c) # Conflicts: # docs/static/releasenotes.asciidoc
|
@mergify backport 8.18 |
✅ Backports have been createdDetails
|
* Update release notes for 8.17.5 * Filter out non-user facing commits/changes from release notes * Update based on PR review Co-authored-by: Karen Metts <[email protected]> --------- Co-authored-by: logstashmachine <[email protected]> Co-authored-by: donoghuc <[email protected]> Co-authored-by: Karen Metts <[email protected]> (cherry picked from commit 16ee40c) # Conflicts: # docs/static/releasenotes.asciidoc
* Release notes for 8.17.5 (#17550) * Update release notes for 8.17.5 * Filter out non-user facing commits/changes from release notes * Update based on PR review Co-authored-by: Karen Metts <[email protected]> --------- Co-authored-by: logstashmachine <[email protected]> Co-authored-by: donoghuc <[email protected]> Co-authored-by: Karen Metts <[email protected]> (cherry picked from commit 16ee40c) # Conflicts: # docs/static/releasenotes.asciidoc * Resolve merge conflict from mergify cherry-pick --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: donoghuc <[email protected]>
* Release notes for 8.17.5 (#17550) * Update release notes for 8.17.5 * Filter out non-user facing commits/changes from release notes * Update based on PR review Co-authored-by: Karen Metts <[email protected]> --------- Co-authored-by: logstashmachine <[email protected]> Co-authored-by: donoghuc <[email protected]> Co-authored-by: Karen Metts <[email protected]> (cherry picked from commit 16ee40c) # Conflicts: # docs/static/releasenotes.asciidoc * Resolve merge conflict from mergify cherry-pick --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: donoghuc <[email protected]>
No description provided.