Update release notes after non-nullable string setting fix was merged #17545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisecheng
reviewed
Apr 10, 2025
|
|
||
| [[notable-8.18.0]] | ||
| ==== Performance improvements and notable issues fixed | ||
| * Fixes an issue introduced in 8.16.4, 8.17.2 where null values were incorrectly accepted for non-nullable settings https://github.com/elastic/logstash/pull/17522[#17522]. |
Contributor
There was a problem hiding this comment.
How about removing versions detail?
Contributor
There was a problem hiding this comment.
Fixes an issue where null values were incorrectly accepted for mandatory string settings
Contributor
Author
There was a problem hiding this comment.
It's a regression introduced specifically in those versions, so specifying the version would help to consume the notes, I think.
kaisecheng
approved these changes
Apr 10, 2025
Contributor
kaisecheng
left a comment
kaisecheng
left a comment
There was a problem hiding this comment.
I left a suggestion for you to consider, otherwise, LGTM
kaisecheng
approved these changes
Apr 10, 2025
Contributor
Author
|
@mergify backport 8.x |
Contributor
✅ Backports have been createdDetails
|
andsel
added a commit
that referenced
this pull request
Apr 15, 2025
…ix was merged to 8.x (#17545) (#17557) (cherry picked from commit 76e1de2) Co-authored-by: Andrea Selva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release notes after backport of #17522