Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] debug ls2ls spec #17218

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] debug ls2ls spec #17218

wants to merge 1 commit into from

Conversation

kaisecheng
Copy link
Contributor

No description provided.

@mergify Mergify
Copy link

mergify bot commented Mar 4, 2025

This pull request does not have a backport label. Could you fix it @kaisecheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link

mergify bot commented Mar 4, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 4, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

mashhurs
mashhurs reviewed Mar 4, 2025
View reviewed changes
qa/integration/specs/logstash_to_logstash_spec.rb
try(num_retries) do
downstream_event_stats = downstream_logstash_service.monitoring_api.event_stats
upstream_event_stats = upstream_logstash_service.monitoring_api.event_stats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dangerous part here, upstream has a generator input, which we don't have guarantee it and its monitoring API are live. That's why we didn't include the upstream expectation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashhurs mashhurs mashhurs left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaisecheng @elasticmachine @mashhurs