Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: experiment with compressing the persistent queue data #17128

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Feb 20, 2025

since compression can be quite cheap compared to i/o, maybe we could default to compressing the data being written to the PQ.

this is a draft and shows a significant performance in performance, moving the bottleneck closer to the cbor mapper deserialization instead of PQ writing in my local laptop.

such a change must be however evaluated as to not introduce breaking changes, potentially with a V3 PQ format.

code-wise Logstash::Event could move to a extension of the Queueable interface that allows compression.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 20, 2025

Copy link

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @jsvd? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants