Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow capturing heap dumps in DRA BK jobs #17081

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

dliappis
Copy link
Contributor

Release notes

[rn:skip]

What does this PR do?

This commit allows Buildkite to capture any heap dumps produced during DRA builds.

Why is it important/What is the impact to the user?

Eases investigating failing builds like https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/2231#0194fd28-acc5-4f24-9f06-66e52b3f0567

This commit allows Buildkite to capture any heap dumps produced
during DRA builds.
@dliappis dliappis self-assigned this Feb 13, 2025
@dliappis dliappis requested a review from jsvd February 13, 2025 12:45
@dliappis
Copy link
Contributor Author

@jsvd Tried a test build https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/2235#0194ff1b-c535-45b6-b16e-7b05e5bfcf2d but life often has it, the problem didn't reproduce, hence no hprof captured.

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @dliappis

@dliappis dliappis merged commit 78c3446 into elastic:main Feb 13, 2025
7 checks passed
@dliappis
Copy link
Contributor Author

@logstashmachine backport 9.0

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.x

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.18

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.17

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.16

@dliappis
Copy link
Contributor Author

@logstashmachine backport 7.17

github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)
github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)
github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)
github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)
github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)
github-actions bot pushed a commit that referenced this pull request Feb 13, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)
dliappis added a commit that referenced this pull request Feb 14, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 14, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 14, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 14, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Feb 14, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.

(cherry picked from commit 78c3446)

Co-authored-by: Dimitrios Liappis <[email protected]>
v1v pushed a commit to v1v/logstash that referenced this pull request Feb 25, 2025
This commit allows Buildkite to capture any heap dumps produced
during DRA builds.
v1v added a commit to v1v/logstash that referenced this pull request Feb 25, 2025
…gify

* upstream/main: (27 commits)
  Add Windows 2025 to CI (elastic#17133)
  Update container acceptance tests with stdout/stderr changes (elastic#17138)
  entrypoint: avoid polluting stdout (elastic#17125)
  Fix acceptance test assertions for updated plugin remove (elastic#17126)
  Fix acceptance test assertions for updated plugin `remove` (elastic#17122)
  plugins: improve `remove` command to support multiple plugins (elastic#17030)
  spec: improve ls2ls spec (elastic#17114)
  allow concurrent Batch deserialization (elastic#17050)
  CPM handle 404 response gracefully with user-friendly log (elastic#17052)
  qa: use clean expansion of LS tarball per fixture instance (elastic#17082)
  Allow capturing heap dumps in DRA BK jobs (elastic#17081)
  Use centralized source of truth for active branches (elastic#17063)
  Update logstash_releases.json (elastic#17055)
  fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039)
  Don't honor VERSION_QUALIFIER if set but empty (elastic#17032)
  Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026)
  Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968)
  Add short living 9.0 next and update main in CI release version definition. (elastic#17008)
  Core version bump to 9.1.0 (elastic#16991)
  Add 9.0 branch to the CI branches definition (elastic#16997)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants