Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Java 21 default in docs. #17046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mashhurs
Copy link
Contributor

Release notes

[rn:skip]

What does this PR do?

Updates the JVM doc saying Java 17 is default. Unfortunately we changed it to Java 21 a way back.

Why is it important/What is the impact to the user?

Deliver accurate message about JDK

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@mashhurs mashhurs added the docs label Feb 10, 2025
Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

📃 DOCS PREVIEWhttps://logstash_bk_17046.docs-preview.app.elstc.co/diff

@yaauie yaauie changed the title Mark Java 12 default in docs. Mark Java 21 default in docs. Feb 10, 2025
@yaauie
Copy link
Member

yaauie commented Feb 10, 2025

The asciidoc for main are frozen now; can you re-open a new PR against 8.x?

@mashhurs mashhurs changed the base branch from main to 8.x February 10, 2025 22:02
@mashhurs mashhurs changed the base branch from 8.x to main February 10, 2025 22:02
@mashhurs
Copy link
Contributor Author

The asciidoc for main are frozen now; can you re-open a new PR against 8.x?

8.x: #17047
9.0: #17048

@robbavey
Copy link
Member

Related: #16608

Copy link
Contributor

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

📃 DOCS PREVIEWhttps://logstash_bk_17046.docs-preview.app.elstc.co/diff

Copy link

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
Copy link

mergify bot commented Mar 5, 2025

This pull request is now in conflicts. Could you fix it @mashhurs? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b docs-make-jdk12-default upstream/docs-make-jdk12-default
git merge upstream/main
git push upstream docs-make-jdk12-default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants