Skip to content

Allow spaces in field references #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow spaces in field references #1513

wants to merge 1 commit into from

Conversation

@jordansissel
Copy link
Contributor

@jordansissel jordansissel commented Jul 9, 2014

This should permit [field references][with spaces][in them]

@elasticsearch-release
Copy link

elasticsearch-release commented Jul 9, 2014

💚 Test passed.
Refer to this link for build results: http://jenkins.elasticsearch.org/job/Logstash_PR/12/

jordansissel added a commit to jordansissel/logstash that referenced this pull request Aug 1, 2014
@jordansissel
config grammar: Allow spaces in [field references][like this]
3c5de85 
Tests included.

Note about grammar compilation:
  I had to use treetop 1.4.15 (1.5.3 generates ruby code that fails to
  parse, haven't spent any time debugging)

Fixes elastic#1513
@elasticsearch-release
Copy link

elasticsearch-release commented Aug 1, 2014

💚 Test passed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/62/

@jordansissel
config grammar: Allow spaces in [field references][like this]
8237348 
Tests included.

Note about grammar compilation:
  I had to use treetop 1.4.15 (1.5.3 generates ruby code that fails to
  parse, haven't spent any time debugging)

Fixes elastic#1513
@elasticsearch-release
Copy link

elasticsearch-release commented Aug 1, 2014

💚 Test passed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/63/

@elasticsearch-release
Copy link

elasticsearch-release commented Aug 1, 2014

💚 Test passed.
Refer to this link for build results: http://build-eu-1.elasticsearch.org/job/Logstash_PR/64/

jordansissel
jordansissel reviewed Aug 1, 2014
View reviewed changes
spec/conditionals/test.rb
Copy link
Contributor Author

@jordansissel jordansissel Aug 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo correction :P

@jordansissel
Copy link
Contributor Author

jordansissel commented Aug 1, 2014 

Finished in 33.64 seconds
601 examples, 0 failures

jordansissel added a commit that referenced this pull request Aug 1, 2014
@jordansissel
config grammar: Allow spaces in [field references][like this]
384dffd 
Tests included.

Note about grammar compilation:
  I had to use treetop 1.4.15 (1.5.3 generates ruby code that fails to
  parse, haven't spent any time debugging)

Fixes #1513
@jordansissel jordansissel added this to the v1.5.0 milestone Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jordansissel @elasticsearch-release