Skip to content

Backport PR #12861 to 7.x: Allow per-pipeline config of ECS Compatibility mode via Central Management#13001

Closed
yaauie wants to merge 1 commit into7.16from
backport_12861_7.x
Closed

Backport PR #12861 to 7.x: Allow per-pipeline config of ECS Compatibility mode via Central Management#13001
yaauie wants to merge 1 commit into7.16from
backport_12861_7.x

Conversation

@yaauie
Copy link
Member

@yaauie yaauie commented Jun 17, 2021

Backport PR #12861 to 7.x branch. Original message:

Release notes

When using Kibana's Central Management for Logstash, values for pipeline.ordered and pipeline.ecs_compatibility settings are now supported.

What does this PR do?

Brings pipeline.ordered and pipeline.ecs_compatibility settings into the supported set here on the Logstash side so that they will be respected when provided by a pipeline that is managed by Kibana's Central Management for Logstash. Currently, the Kibana UI does not support setting these in the pipeline editor, but allows unvalidated k/v settings through pipelines managed through its API.

This PR does NOT include the necessary changes to Kibana's pipeline editor to make these UI-accessible (hint: here?) or Kibana's API documentation (hint: here).

Why is it important/What is the impact to the user?

Allows a user to configure the ECS Compatibility or Strict Ordering settings of a pipeline when that pipeline is managed by Kibana's Central Management for Logstash.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

How to test this PR locally

Using Kibana's API, persist a pipeline with the settings pipeline.ordered and/or pipeline.ecs_compatibility. Observe that without this PR they are ignored, but with this PR they are respected.

…ement (#12861)

* spec: noop refactor of xpack central management

* spec: validate central management settings loading

* central management: allow pipeline.ordered and pipeline.ecs_compatibility settings

(cherry picked from commit 49e6b0e)
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

believe you want to merge to 7.17

@yaauie yaauie closed this Apr 27, 2022
@jsvd jsvd deleted the backport_12861_7.x branch June 2, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants