Revert bundler version #12910
Closed
Revert bundler version #12910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of bundler (> 2.2.3) have changed the resolution to resolve for the specific running platform, using the specific platform triple, such as `universal-java-1.8`, rather than `java`, as was previously the case, meaning that the 'PLATFORMS` section of the `Gemfile.lock` will change from: ``` PLATFORMS java ``` after: ``` PLATFORMS universal-java-1.8 ``` At runtime, unless bundler is run in frozen mode, this value is resolved again at runtime, and depending on whether the platform being run in matches that being built on, `Gemfile.lock` is resolved to match the running platform - which now causes a runtime error when running Logstash as a service, as the running application no longer has write permission on `Gemfile.lock` after elastic#12782. While this should fix elastic#12818, we should look into a permanent solution to enable us to keep up with bundler updates.
yaauie
requested changes
May 13, 2021
build.gradle
Outdated
| dependsOn installBundler | ||
| doLast { | ||
| setupJruby(projectDir, buildDir) | ||
| setupJruby(projectDir, buildDir.1.4) |
Member
There was a problem hiding this comment.
Suggested change
| setupJruby(projectDir, buildDir.1.4) | |
| setupJruby(projectDir, buildDir) |
Member
Author
|
@yauuie - ready for re-review |
5 tasks
Member
Author
|
#13015 removes the need for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of bundler (> 2.2.3) have changed the resolution to resolve
for the specific running platform, using the specific platform triple, such
as
universal-java-1.8, rather thanjava, as was previously the case, meaningthat the 'PLATFORMS
section of theGemfile.lock` will change from:after:
At runtime, unless bundler is run in frozen mode, this value is resolved again at
runtime, and depending on whether the platform being run in matches that being built
on,
Gemfile.lockis resolved to match the running platform - which now causes aruntime error when running Logstash as a service, as the running application no longer
has write permission on
Gemfile.lockafter #12782.While this should fix #12818, we should look into a permanent solution to enable us to
keep up with bundler updates.
Release notes
What does this PR do?
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs