fix DLQ integration tests #12871
Merged
fix DLQ integration tests #12871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
force-pushed
the
fix_integration_tests
branch
from
9045fa1 to
c9f68fe
Compare
5 tasks
andsel
approved these changes
May 6, 2021
Contributor
andsel
left a comment
andsel
left a comment
There was a problem hiding this comment.
LGTM, only tiny doubt on the change of pipeline.batch.size
| "dead_letter_queue.enable" => true, | ||
| "pipeline.batch.size" => 1, | ||
| "config.string" => "input { generator { message => '#{message}' codec => \"json\" count => 1000 } } filter { mutate { add_field => { \"geoip\" => \"somewhere\" } } } output { elasticsearch {} }" | ||
| "pipeline.batch.size" => 100, |
Contributor
There was a problem hiding this comment.
The downsize of the batch size is it functional to the test or to the fact that now it's single node cluster?
Contributor
There was a problem hiding this comment.
don't mind my comment, I thought it passed from 100 to 1, but it's opposite and is reasonable to have a batch greater than the unit
Member
Author
There was a problem hiding this comment.
yeah having size 1 was making these tests unnecessarily slow
andsel
added a commit
that referenced
this pull request
May 6, 2021
kares
added a commit
to kares/logstash
that referenced
this pull request
May 10, 2021
* master: fix DLQ integration tests (elastic#12871) Fix ES HOW integration tests on `master` (elastic#12872) Update logstash_releases.json Support for UTF-16 and other multi-byte-character logfiles (elastic#9702) change download path for geoip plugin (elastic#12863) Change Gradle's :logstash-integration-tests:integrationTests task to depends on copyES (elastic#12847) Doc: Keystore must be accessible to logstash user (elastic#12775) Remove json ~>1 pinning (elastic#12851) Adapted install/uninstall/list PluginManager's command to respect the alised plugins (elastic#12821) Load a plugin by alias name. (elastic#12796)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the DLQ integration tests to not rely on default names of indices for writing data to ES.
Also ensures ES is started in a single node mode.
These changes remove some of the magic of the integration test, where we relied on a index having a template with a geoip field with geo data types already. In these commits we explicitly push a template and then use a message that clearly clashes with that template.