Remove ruby pipeline #12496
Merged
Remove ruby pipeline #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
andsel
reviewed
Dec 9, 2020
There was a problem hiding this comment.
Hi @kaisecheng great work, I've left some notes about parts that aren't clear to me
logstash-core/lib/logstash/runner.rb
Outdated
| @@ -365,8 +365,7 @@ def execute | |||
| # TODO(ph): make it better for multiple pipeline | |||
| if results.success? | |||
| results.response.each do |pipeline_config| | |||
| pipeline_class = pipeline_config.settings.get_value("pipeline.java_execution") ? LogStash::JavaPipeline : LogStash::BasePipeline | |||
| pipeline_class.new(pipeline_config) | |||
| LogStash::JavaPipeline.new(pipeline_config) | |||
There was a problem hiding this comment.
this could be put in one-liner
results.response.each { |pipeline_config| LogStash::JavaPipeline.new(pipeline_config) }| @@ -47,7 +47,7 @@ | |||
| LogStash::SETTINGS.set_value("monitoring.enabled", false) | |||
| end | |||
|
|
|||
| let(:pipeline) { LogStash::Pipeline.new(config) } | |||
| let(:pipeline) { LogStash::JavaPipeline.new(config, nil) } | |||
There was a problem hiding this comment.
nil as second parameter shouldn't be needed due to JavaPipeline#initialize signature:
def initialize(pipeline_config, namespaced_metric = nil, agent = nil)
andsel
approved these changes
Dec 14, 2020
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #11236
This PR removes the Ruby Execution Engine
The Java Execution Engine has been the default engine since Logstash 7.0, and is capable of using plugins written in either Ruby or Java; removing the Ruby Execution Engine will not affect our ability to run existing pipelines, but will greatly reduce the surface area of all features and fixes within the engine(s). We will no longer need to target two engines simultaneously.