Skip to content

Comments

[Doc]Doc updates for internal collectors#11789

Merged
karenzone merged 3 commits intoelastic:masterfrom
karenzone:monitoring-take4
Apr 16, 2020
Merged

[Doc]Doc updates for internal collectors#11789
karenzone merged 3 commits intoelastic:masterfrom
karenzone:monitoring-take4

Conversation

@karenzone
Copy link
Contributor

@karenzone karenzone commented Apr 14, 2020

@karenzone
Copy link
Contributor Author

cc:/ @robbavey @andsel

//TODO: Verify the following sentence:

IMPORTANT: When discussing security relative to the `elasticsearch` output,
remember that all users are managed on the production cluster, which is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the monitoring cluster, and maybe should mention monitoring.elasticsearch settings rather than "elasticsearch output" for clarity?

monitoring.elasticsearch.hosts: [ "http://localhost:9200" ]
---------------------------------------------------

//TODO: Verify the following sentence:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 16 Do we want to surface this further up? This content was dropped down in the restructure, and it feels like it might be something we want to surface higher.

a minimal impact on ordinary Logstash processing. Existing Logstash features,
such as the <<plugins-outputs-elasticsearch,`elasticsearch` output>>, can be
reused to benefit from its retry policies.
a minimal impact on ordinary Logstash processing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some comments here for content in lines above:

Line 26 - this doesn't appear to tally with the current settings for Elasticsearch, which still refer to xpack.monitoring.collection.enabled

Line 39 The example URL should indicate that it is a monitoring node, rather than a prod node

//TODO: Verify the following sentence:

All data produced by Logstash monitoring is indexed in the monitoring
cluster by using the `.monitoring-logstash` template, which is managed by the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer uses exporters for internal collection

@karenzone karenzone marked this pull request as ready for review April 16, 2020 19:12
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot
Copy link

Karen Metts merged this into the following branches!

Branch Commits
7.7 0c0c268, cb6f132, 2b6c9cd
7.x b67ffce, 7b68aee, da7de67

elasticsearch-bot pushed a commit that referenced this pull request Apr 16, 2020
elasticsearch-bot pushed a commit that referenced this pull request Apr 16, 2020
elasticsearch-bot pushed a commit that referenced this pull request Apr 16, 2020
elasticsearch-bot pushed a commit that referenced this pull request Apr 16, 2020
elasticsearch-bot pushed a commit that referenced this pull request Apr 16, 2020
elasticsearch-bot pushed a commit that referenced this pull request Apr 16, 2020
@karenzone karenzone merged commit 8323106 into elastic:master Apr 16, 2020
@karenzone karenzone deleted the monitoring-take4 branch April 30, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants