Apply upstream ES EserAgentPlugin refactoring changes#408
Merged
mashhurs merged 6 commits intoelastic:mainfrom Mar 12, 2026
Merged
Apply upstream ES EserAgentPlugin refactoring changes#408mashhurs merged 6 commits intoelastic:mainfrom
mashhurs merged 6 commits intoelastic:mainfrom
Conversation
|
This pull request does not have a backport label. Could you fix it @mashhurs? 🙏
|
mashhurs
commented
Mar 9, 2026
mashhurs
changed the title
Member
|
Looks like this needs a rebase on main to get the updated certs. |
mashhurs
force-pushed
the
user-agent-rename-test
branch
from
d0a4ce8 to
1b7e22e
Compare
Collaborator
Author
Yep, just rebased. |
donoghuc
reviewed
Mar 12, 2026
build.gradle
Outdated
| /** | ||
| * Shades the Elasticsearch user-agent-api lib (built as part of localDistro). | ||
| */ | ||
| task shadeElasticsearchUserAgentApi(type: com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar) { |
Member
There was a problem hiding this comment.
I'm confused what this is for? I dont see how this is called anywhere? Is this something for local dev?
Collaborator
Author
There was a problem hiding this comment.
Your confusion is valid :) I added include jarPackageNamed("elasticsearch-user-agent-api") after I confirmed upstream ES refactoring change produces the JAR, disabled the task but forgot to remove. I have just removed.
Collaborator
💚 Build Succeeded
History
cc @mashhurs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the ongoing effort to refactoring
UesrAgentPluginelastic/elasticsearch#140712FYI: no backport needed.