Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 5, 2019

Asciidoctor needs quotes around any macro paramters with , in it. This
fixes up one such tag.

Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.
@karenzone
Copy link
Contributor

karenzone commented Aug 5, 2019

Thanks, @nik9000. I have mirrored this fix in the source repo: logstash-plugins/logstash-output-google_bigquery#53

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot
Copy link

Karen Metts merged this into the following branches!

Branch Commits
7.0 93b81a7
7.1 16ced22
7.2 4bd7689
7.3 1c5b365
7.x f2f2e14

elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
@elasticsearch-bot
Copy link

Karen Metts merged this into the following branches!

Branch Commits
6.5 65ed164
6.6 f45e753
6.7 5d23928
6.8 77e11e1

elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
@elasticsearch-bot
Copy link

Karen Metts merged this into the following branches!

Branch Commits
6.3 0687603
6.4 6ac8a83

elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
elasticsearch-bot pushed a commit that referenced this pull request Aug 5, 2019
Asciidoctor needs quotes around any macro paramters with `,` in it. This
fixes up one such tag.

Fixes #779
@nik9000
Copy link
Member Author

nik9000 commented Aug 5, 2019

Thanks!

@nik9000 nik9000 merged commit e3878a0 into elastic:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants