remove logstash/pipeline #89
Conversation
| @@ -1,4 +1,3 @@ | |||
| require "logstash/pipeline" | |||
There was a problem hiding this comment.
sorry for the late review but we also have require "logstash/pipeline" around in a few specs:
- logstash-integration-rabbitmq
- logstash-mixin-rabbitmq_connection only used by output-rebbitmq and input-rabbitmq which have been replaced by the integration-rabbitmq plugin
- logstash-output-jira just a test stub and pretty much not supported
There was a problem hiding this comment.
was there a conscious decision not to keep require "logstash/pipeline" around (as a delegate to require "logstash/java_pipeline") ?
There was a problem hiding this comment.
Thanks for reviewing the PR. I checked the support matrix and missed integration-rabbitmq, mixin-rabbitmq. Most likely I only checked the input- and output-.
We didn't discuss in detail the ways of removing the dependency. My idea was to remove unrelated legacy completely, but I agree given that there are 70+ plugins to maintain, pointing LogStash::Pipeline to JavaPipeline is a better way to keep every plugin include the unsupported one work
Fixed: elastic/logstash#11236
This PR remove ruby pipeline dependency